Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent games - no backgounds #24

Open
Negatifff opened this issue Sep 11, 2018 · 7 comments
Open

Recent games - no backgounds #24

Negatifff opened this issue Sep 11, 2018 · 7 comments

Comments

@Negatifff
Copy link

Good day.
I'm russian and english is not my native language, so... :)
In ES main menu "Recent" (Last played) menu w/o background. And when I enter into recent I see like "no css". You understand, I hope.

Can I fix it myself? Or?

@preaction
Copy link

I see the same thing on the Favorites and the All Games collections. It looks like these auto collections get their own folders (auto-favorites, auto-lastplayed, and auto-allgames). I'm not sure what would go here for a background, but at least the layout of the list could be the same.

@raelgc
Copy link
Collaborator

raelgc commented Sep 19, 2018

Sorry for the dumb question, but can you, please, provide steps to reproduce this? I'm not that used to collections and favorites, so I'm facing a hard time trying to reproduce.

@preaction
Copy link

You need to enable the auto collections from the EmulationStation main menu. Go to the Game Collections menu, then go into Automatic Game Collections, and enable them all. Then go back out to the list of game systems and see the words "all", "recent", and "favorite" in the list of game systems. There's no background image to accompany these when selected. Entering one of these shows the unstyled game menu: The game titles are blue on a black background, the box art appears, but some of the UI text underneath seems to be black.

@raelgc
Copy link
Collaborator

raelgc commented Sep 19, 2018

Thanks @preaction! Now I can see!

preaction added a commit to preaction/es-theme-tronkyfran that referenced this issue Sep 20, 2018
This adds configuration for auto collections so they do not use the
default theme, a theme for the "group unthemed custom collections"
configuration, as well as a default theme so that when custom
collections are ungrouped, they still look nice.

The auto collections use icons from Font Awesome along with text drawn
into the SVG using
https://danmarshall.github.io/google-font-to-svg-path/ (since I could
not get <text> elements to work in the SVGs...)

All of these screens use the RetroPie background as I could not think of
any better background. A simple radial gradient background could work
nicely though...

Fixes HerbFargus#24
@preaction
Copy link

I put together a possible fix for this issue. I don't know if using FontAwesome icons is quite in spirit with the theme, but I needed to put something other than text in the menu so it would look like it belongs with the rest of the logos. I also didn't know what background to use, so I used the RetroPie background (since I have a RetroPie, it seems logical that system-related stuff like this would use the same background).

@Negatifff
Copy link
Author

Negatifff commented Sep 20, 2018

Hello
I already fix my issue for me. if someone interesting it - share in the evening.

@GabeKnuth
Copy link

GabeKnuth commented Oct 31, 2018

I just submitted a PR that will address this. I created graphics for all three auto collections using either homemade stuff or freely-available fonts/images. The Favorites BG even came from tronkyfran via the RetroPie forum.

img_5308
img_5306
img_5305
img_5307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants