Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: List your own playlists #7

Open
benwoodward opened this issue Nov 14, 2019 · 6 comments
Open

Feature Request: List your own playlists #7

benwoodward opened this issue Nov 14, 2019 · 6 comments

Comments

@benwoodward
Copy link

Would be great to have a command that lists all of your playlists, allowing you to select one to play.

@benwoodward
Copy link
Author

@BachoSeven Added this feature in a fork if you want to try it out: https://github.com/benwoodward/vimify/tree/playlists

@BachoSeven
Copy link

BachoSeven commented Jan 6, 2020

@benwoodward Nice! I think the process of generating the client auth token is easier now.

It works, but there's an offset in the selection of playlists, meaning <Enter> actually plays the playlist above the cursor.
Other than that, is there a specific reason why the output of ListPlaylists() is limited to 20 results? I raised the minimum to 50 and it works fine.

Also, when a playlist contains >=80 songs, vimify only queues the first 80 songs on the list; and if it has >=160 songs the it queues the first 160(excluding the first one). This, I cannot figure out why.

@benwoodward
Copy link
Author

benwoodward commented Jan 7, 2020

@BachoSeven Great, thanks for testing it.

It works, but there's an offset in the selection of playlists, meaning actually plays the playlist above the cursor.

I have an idea about what causes this.

Other than that, is there a specific reason why the output of ListPlaylists() is limited to 20 results? I raised the minimum to 50 and it works fine.

I did raise the query limit to 50, but maybe it wasn't implemented properly. Thanks for flagging this.

Also, when a playlist contains >=80 songs, vimify only queues the first 80 songs on the list; and if it has >=160 songs the it queues the first 180(excluding the first one). This, I cannot figure out why.

Good catch! That's an odd one. Perhaps @HendrikPetertje has some insight into what could cause that. I'll look into it.

@benwoodward
Copy link
Author

@BachoSeven I fixed the offset issue, and the 20 Playlist limit issue. Will look at the other one when I have more time.

@HendrikPetertje
Copy link
Owner

wow nice!
I will give this a look when I get out of the office today!

@fira42073
Copy link

fira42073 commented Mar 11, 2022

Are there updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants