[BUG] Display - Fade as unusable /desaturate behavior

[Williamn88]

Before You Begin

• I confirm that I have downloaded the latest version of the addon.
• I am not playing on a private server.
• I checked for an existing, open ticket for this issue and was not able to find one.
• I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

Fade as unusable /desaturate does not seem to work anymore in the latest version.
Im not really sure what to provide, but I guess here is a screenshot of the settings being checked, just pressed a abililty but the icons look normal like its not on.

It used to be desaturate the whole icon while GCD was going on and such. Turning the settings on and off does not seem to change anything atm.

How to Reproduce

Check settings is on, press ability, watch the icons

Player Information (Link)

https://pastebin.com/LeHmecU5

Error Messages (Link)

NA

Additional Information

No response

Contact Information

No response

[johnnylam88]

This was a change made recently that I believe fixed a bug in the previous behavior. Those settings are for delays which cover when a recommended ability needs to be delayed past the next GCD or when the ability's cooldown is ready. Basically if you can spam the recommended ability while waiting for it to be ready, then it's not considered a delay.

I could submit a change that restored the old behavior where the icon is faded and desaturated until the recommended ability can be cast, but you would not be able to differentiate when you can safely queue the recommended ability versus needing to actually wait to cast it. I'm interested in what @Hekili thinks is the correct behavior.

[Williamn88]

I see. It does sound like it makes sense. I just visually liked how it was before and have been used to that.

We already have quite a bit of toggles in there, but could the old behavior maybe be something you can select ?

[Hekili]

I'll keep an eye on this, but @johnnylam88 is correct about the delay behavior. There may be room for a "desaturate on cooldown" vs. "desaturate when delayed" but I need to revisit the design intent.