Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Проверка покрытия тестами изменений в PR #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP]: Проверка покрытия тестами изменений в PR #81

wants to merge 5 commits into from
+52 −13

Conversation

EgorBazhenov
Copy link
Collaborator

No description provided.

@EgorBazhenov EgorBazhenov linked an issue Jun 9, 2024 that may be closed by this pull request
Добавить отображения непокрытых строк в PR #40
Open
@EgorBazhenov EgorBazhenov added the github_actions Pull requests that update GitHub Actions code label Jun 9, 2024
@EgorBazhenov EgorBazhenov force-pushed the feature/issue-40_pull_request_test_coverage branch from 7d8f6b1 to b4e1282 Compare June 9, 2024 11:36
@EgorBazhenov EgorBazhenov force-pushed the feature/issue-40_pull_request_test_coverage branch 2 times, most recently from 0890fc0 to f93c39e Compare June 9, 2024 11:49
@EgorBazhenov EgorBazhenov changed the title Проверка покрытия тестами изменений в PR [WIP]: Проверка покрытия тестами изменений в PR Jun 9, 2024
@EgorBazhenov
Copy link
Collaborator Author

Промежуточный итог.
Локально удалось поставить-настроить-запустить undercover, однако, внутри CI undercover не видит ветку main. Возможно, это связано с тем, что checkout-action копирует только последний коммит. В общем, здесь я пока застрял. Чтобы не заниматься дебагом/экспириментами в PR, я буду ставить https://github.com/nektos/act, для локального запуска CI.

P.S: @sergio-fry, извиняюсь, слишком рано запросил review

@EgorBazhenov EgorBazhenov force-pushed the feature/issue-40_pull_request_test_coverage branch from f93c39e to 3d5e345 Compare June 9, 2024 15:09
sergio-fry
sergio-fry requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@sergio-fry sergio-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Понял, ждем.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-fry sergio-fry sergio-fry requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Добавить отображения непокрытых строк в PR
2 participants
@EgorBazhenov @sergio-fry