Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal | Pressing Escape "soft closes" the modal if onClickOutside isn't set #485

Open
1 task
aVileBroker opened this issue Oct 26, 2023 · 0 comments
Open
1 task

Modal | Pressing Escape "soft closes" the modal if onClickOutside isn't set #485

aVileBroker opened this issue Oct 26, 2023 · 0 comments
Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers

Comments

@aVileBroker
Copy link
Contributor

aVileBroker commented Oct 26, 2023 •
edited
Loading

If onClickOutside is not set and Esc is pressed, the modal "soft closes", where it doesn't get unmounted (because onClickOutside isn't set) but does animate away. It also blocks the page from interaction as a result.

AC

  • if onClickOutside isn't set, do nothing when Esc is pressed
@aVileBroker aVileBroker added bug Something isn't working good first issue Good for newcomers 0.5 Story Points issue size: .5 labels Oct 26, 2023
@betsay27 betsay27 mentioned this issue Nov 2, 2023
Merged
aVileBroker added a commit that referenced this issue Nov 2, 2023
@aVileBroker
485: When Modal onClickOutside=false Esc key causes failure (#488)
429733f 
Fix for issue #485 

When Modal onClickOutside=false, pressing the Esc key will cause the
modal to be hidden when the expected behavior is that an Esc key press
would do nothing.

Tests pass and no known issues have arisen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.5 Story Points issue size: .5 bug Something isn't working good first issue Good for newcomers
Projects
Foundry-React-UI
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aVileBroker