Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component | MainNavigation #331

Open
aVileBroker opened this issue Sep 12, 2021 · 0 comments
Open

New Component | MainNavigation #331

aVileBroker opened this issue Sep 12, 2021 · 0 comments
Labels
1 Story Point Story points: 1 help wanted Extra attention is needed new component New base component

Comments

@aVileBroker
Copy link
Contributor

I had previously made the point to not create any application-specific components like this, but given we have composed components like "Card" which simply follow a pattern, I feel like we can provide a simple container which is extensible.

Propose your own API and features! I'll make some suggestions below, but feel free to be creative. <3

  • Container (component, props, ref) - horizontal flexbox
  • Left (head?), middle (body?), and right (footer?) for hamburger menu/logo, links/tabs, and CTA buttons etc.
  • Attachment options like absolute, sticky, etc?
  • Would be cool to expose scroll pos/velocity info to the subcomponents so it can hide/condense as the user scrolls
@aVileBroker aVileBroker added the enhancement New feature or request label Sep 12, 2021
@aVileBroker aVileBroker added 1 Story Point Story points: 1 help wanted Extra attention is needed new component New base component and removed enhancement New feature or request labels Sep 12, 2021
@PatrickDeVries PatrickDeVries self-assigned this Oct 11, 2021
@PatrickDeVries PatrickDeVries linked a pull request Oct 18, 2021 that will close this issue
@PatrickDeVries PatrickDeVries removed their assignment Oct 27, 2021
@aVileBroker aVileBroker reopened this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Story Point Story points: 1 help wanted Extra attention is needed new component New base component
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants