Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] BaseConnection method extraction #535

Open
tuliomir opened this issue May 29, 2023 · 0 comments
Open

[Refactor] BaseConnection method extraction #535

tuliomir opened this issue May 29, 2023 · 0 comments
Labels

Comments

@tuliomir
Copy link
Contributor

On #533 there was a discussion on inheriting too many methods that are only useful for fullnode Websocket connections when connecting to other kinds of servers ( ex.: Atomic Swap Service )

It would be a good idea to refactor these fullnode-specific methods into a new core-connection file. This would imply on also refactoring the wallet-service websocket, that already inherits these unnecessary methods.

The concept of the BaseConnection itself would be re-evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant