You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On #533 there was a discussion on inheriting too many methods that are only useful for fullnode Websocket connections when connecting to other kinds of servers ( ex.: Atomic Swap Service )
It would be a good idea to refactor these fullnode-specific methods into a new core-connection file. This would imply on also refactoring the wallet-service websocket, that already inherits these unnecessary methods.
The concept of the BaseConnection itself would be re-evaluated.
The text was updated successfully, but these errors were encountered:
On #533 there was a discussion on inheriting too many methods that are only useful for
fullnode
Websocket connections when connecting to other kinds of servers ( ex.: Atomic Swap Service )It would be a good idea to refactor these fullnode-specific methods into a new
core-connection
file. This would imply on also refactoring thewallet-service
websocket, that already inherits these unnecessary methods.The concept of the
BaseConnection
itself would be re-evaluated.The text was updated successfully, but these errors were encountered: