Optimize - change config file generation to a function

utilities.py

@@ -6,11 +6,11 @@
 import yaml
 from yaml import SafeLoader
 
-'''
-#' created by franco, this declaration is made for original config file generation
-#' if the new generater is being used, this one can also be removed
-config_file_content = """# discord_line_bot_config_file 
-Line:
+
+def config_file_generator():
+    """Generate the template of config file"""
+    with open('config.yml', 'w', encoding="utf8") as f:
+        f.write("""Line:
   channel_access_token: ''
   channel_secret: ''
   line_notify_token: ''
@@ -30,44 +30,7 @@
   channel_id: ''
   channel_webhook: ''
 """
-'''
-# A config file generater made by franco23034565
-# Can use the regular expression to check if the token is typed correctly, 
-# but I have no idea what these token actually looks like.
-def config_file_generater():
-    line_channel_access_token = input("input your line channel access token: ")
-    line_channel_secret = input("input your line channel secret: ")
-    line_notify_token = input("input your line notify token: ")
-    line_chat_type = input("input your line chat type: ")
-    line_user_id = input("input your line user id: ")
-    line_group_id = input("input your line group id: ")
-    discord_bot_token = input("input your discord bot token: ")
-    discord_channel_id = input("input your discord channel id: ")
-    discord_channel_webhook = input("input your discord channel webhook: ")
-    with open('config.yml', 'w', encoding="utf8") as f:
-        f.write(
-            f"""# discord_line_bot_config_file 
-Line:
-  channel_access_token: '{line_channel_access_token}'
-  channel_secret: '{line_channel_secret}'
-  line_notify_token: '{line_notify_token}'
-
-  # 以下為聊天室綁定設定:
-  # 聊天室屬性, 目前只有私人訊息以及群組訊息兩種 (user, group)
-  chat_type: '{line_chat_type}'
-
-  # 私人訊息: 請在user_id填入你的line_user_id
-  # 群組訊息: 請在group_id填入你的群組id
-  # 依照上面聊天室屬性對應填入一個即可
-  user_id: '{line_user_id}'
-  group_id: '{line_group_id}'
-
-Discord:
-  bot_token: '{discord_bot_token}'
-  channel_id: '{discord_channel_id}'
-  channel_webhook: '{discord_channel_webhook}'
-"""
-    )
+                )
     sys.exit()
 
 
@@ -79,12 +42,11 @@ def read_config():
 
     :rtype: dict
     """
-    # check if config file exist or not
-    if exists('./config.yml') == False:
+    if not exists('./config.yml'):
         print("Config file not found, create one by default.\nPlease finish filling config.yml")
         with open('config.yml', 'w', encoding="utf8") as f:
-            config_file_generater()
-    
+            config_file_generator()
+
     try:
         with open('config.yml', 'r', encoding="utf8") as f:
             data = yaml.load(f, Loader=SafeLoader)
@@ -100,26 +62,6 @@ def read_config():
                 'discord_channel_webhook': data['Discord']['channel_webhook']
             }
             return config
-
-    ###' commented by franco
-    ###' if the new generater is being used, this one can also be removed
-    #'except FileNotFoundError:
-    #'    print("Config file not found, create one by default.\nPlease finish filling config.yml")
-    #'    with open('config.yml', 'w', encoding="utf8") as f:
-    #'        config_file_generater()
-    #'        '''
-    #'        f.write(config_file_content)
-    #'
-    #'        # original config file strings
-    #'        f.write(
-    #'            "Line:\n  channel_access_token: ''\n  channel_secret: ''\n  line_notify_token: ''\n"
-    #'            "\n  # 以下為聊天室綁定設定:\n  # 聊天室屬性, 目前只有私人訊息以及群組訊息兩種 (user, group)\n"
-    #'            "  chat_type: ''\n\n  # 私人訊息: 請在user_id填入你的line_user_id\n"
-    #'            "  # 群組訊息: 請在group_id填入你的群組id\n  # 依照上面聊天室屬性對應填入一個即可\n"
-    #'            "  user_id: ''\n  group_id: ''\n\n"
-    #'            "Discord:\n  bot_token: ''\n channel_id: ''\n  channel_webhook: ''\n")
-    #'    sys.exit()'''
-    #'
     except (KeyError, TypeError):
         print(
             "An error occurred while reading config.yml, please check if the file is corrected filled.\n"