Skip to content

Commit 196ec56

Browse files
committed
Regenerate mainline library for signal
1 parent e8579c6 commit 196ec56

File tree

5 files changed

+86
-71
lines changed

5 files changed

+86
-71
lines changed

Diff for: CHANGES.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
twilio-node changelog
22
=====================
33

4+
[2017-05-22] Version 3.2.0
5+
--------------------------
6+
7+
- Rename room `Recordings` resource to `RoomRecordings` to avoid class name conflict (backwards incompatible).
8+
49
[2017-05-19] Version 3.1.0
510
--------------------------
611

Diff for: UPGRADE.md

+9
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
11
Upgrade Guide
22

33
After 3.0.0 all MINOR and MAJOR version bumps will have upgrade notes posted here.
4+
5+
[2017-05-22] 3.1.x to 3.2.x
6+
---------------------------
7+
8+
### CHANGED - Rename video room `Recordings` class to `RoomRecordings`
9+
10+
#### Rationale
11+
- This was done to avoid a class name conflict with another resource.
12+
- Client code should be unaffected unless you manipulate the Recording/RoomRecordings class directly. Accessing room recording metadata via the client should work the same way as before.

Diff for: lib/rest/video/v1/room.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
var Q = require('q'); /* jshint ignore:line */
44
var _ = require('lodash'); /* jshint ignore:line */
55
var Page = require('../../../base/Page'); /* jshint ignore:line */
6-
var RecordingList = require('./room/recording').RecordingList;
6+
var RoomRecordingList = require('./room/recording').RoomRecordingList;
77
var deserialize = require(
88
'../../../base/deserialize'); /* jshint ignore:line */
99
var serialize = require('../../../base/serialize'); /* jshint ignore:line */
@@ -518,7 +518,7 @@ RoomInstance.prototype.update = function update(opts, callback) {
518518
* @memberof Twilio.Video.V1.RoomInstance
519519
* @instance
520520
*
521-
* @returns {Twilio.Video.V1.RoomContext.RecordingList}
521+
* @returns {Twilio.Video.V1.RoomContext.RoomRecordingList}
522522
*/
523523
/* jshint ignore:end */
524524
RoomInstance.prototype.recordings = function recordings() {
@@ -531,7 +531,7 @@ RoomInstance.prototype.recordings = function recordings() {
531531
* @constructor Twilio.Video.V1.RoomContext
532532
* @description Initialize the RoomContext
533533
*
534-
* @property {Twilio.Video.V1.RoomContext.RecordingList} recordings -
534+
* @property {Twilio.Video.V1.RoomContext.RoomRecordingList} recordings -
535535
* recordings resource
536536
*
537537
* @param {Twilio.Video.V1} version - Version of the resource
@@ -649,7 +649,7 @@ Object.defineProperty(RoomContext.prototype,
649649
'recordings', {
650650
get: function() {
651651
if (!this._recordings) {
652-
this._recordings = new RecordingList(
652+
this._recordings = new RoomRecordingList(
653653
this._version,
654654
this._solution.sid
655655
);

0 commit comments

Comments
 (0)