Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Immediate drops after connection #1686

Open
mbakholdina opened this issue Dec 1, 2020 · 1 comment · May be fixed by #1707
Open

[BUG] Immediate drops after connection #1686

mbakholdina opened this issue Dec 1, 2020 · 1 comment · May be fixed by #1707
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@mbakholdina
Copy link
Collaborator

mbakholdina commented Dec 1, 2020

Describe the bug

While testing the partial fix for #1648 (see PR #1650), I've encountered another possible issue.

Immediately after connection there are packet drops which are not expected. Here is the log from receiver. Wireshark dumps can be found here.

[haivision@big-flop _build]$ bin/srt-xtransmit receive srt://:4200 -v
11:41:15.199749 [D] SOCKET::SRT 0xAF329A0 (srt://:4200) Listening
11:41:15.199973 [D] SOCKET::SRT 0xAF329A0 (srt://:4200) ASYNC Waiting for incoming connection
11:41:18.433971 [D] SOCKET::SRT 0xAF329A0 (srt://:4200) Accepted connection 0xAF3299F
11:41:18.987026/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21130598 delayed for 0.064 ms
11:41:19.048094/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21130656 delayed for 0.094 ms
11:41:19.091233/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21130697 delayed for 0.085 ms
11:41:19.113340/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21130718 delayed for 0.094 ms
11:41:26.136976/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21137393 delayed for 0.063 ms
11:41:26.144371/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21137395 delayed for 5.354 ms
11:41:26.155402/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21137398 delayed for 13.228 ms
11:41:26.166384/SRT:TsbPd!W:SRT.br: RCV-DROPPED 1 packets, packet seqno 21137405 delayed for 16.844 ms
11:41:31.142593 [D] SOCKET::SRT 0xAF3299F read::recv ERROR 2001 Connection was broken
11:41:31.142660 [W] RECEIVE read::recv: Connection was broken
11:41:31.142688 [D] SOCKET::SRT 0xAF3299F Closing. Releasing epolls
11:41:31.142712 [D] SOCKET::SRT 0xAF3299F Closing

To Reproduce

See this comment for steps to reproduce the problem.

rtt=20ms, latency=default, packet loss=10%, packet burst up to 2 packets (packet loss on both ends)

srt-xtransmit app is used for evaluation, branch develop/jitter-trace-rsptime, Submodule path 'submodule/srt': checked out '019e1fd8bf13fd3d097813a5daba7c34f53225d8'

I am using big-flip (CentOS 7) / big-flop (CentOS 7) / small Lanforge setup.

@mbakholdina mbakholdina added the Type: Bug Indicates an unexpected problem or unintended behavior label Dec 1, 2020
@maxsharabayko
Copy link
Collaborator

Drops happen because of the initial value of NAK period.
Loss report on 21130597 was sent once, retransmission was lost, and there was no more loss report for this packet, so after some time, the receiver dropped it.
Periodic NAK was sent only 150 ms after this loss report because the initial NAK interval is set to 300 ms.

@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Dec 9, 2020
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Dec 9, 2020
@maxsharabayko maxsharabayko self-assigned this Dec 9, 2020
@maxsharabayko maxsharabayko linked a pull request Dec 14, 2020 that will close this issue
2 tasks
@mbakholdina mbakholdina modified the milestones: v1.4.3, v1.4.4 Mar 17, 2021
@maxsharabayko maxsharabayko modified the milestones: v1.4.4, Backlog Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants