Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRT default maximum live payload size 1316 -> 1456 #876

Open
maxsharabayko opened this issue Sep 12, 2019 · 1 comment · May be fixed by #1130
Open

SRT default maximum live payload size 1316 -> 1456 #876

maxsharabayko opened this issue Sep 12, 2019 · 1 comment · May be fixed by #1130
Assignees
@maxsharabayko
Labels
[core] Area: Changes in SRT library core Priority: Medium Type: Maintenance Work required to maintain or clean up the code
Milestone
Major

Comments

@maxsharabayko
Copy link
Collaborator

Use SRT_LIVE_MAX_PLSIZE = 1456; // MTU(1500) - UDP.hdr(28) - SRT.hdr(16)
instead of
SRT_LIVE_DEF_PLSIZE = 1316; // = 188*7, recommended for MPEG TS
by default for live transfer mode.

Still payload of 1316 can be fed into SRT and transmitted.
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Sep 12, 2019
@maxsharabayko maxsharabayko added this to the v1.4.1 milestone Sep 12, 2019
@ethouris
Copy link
Collaborator

The SRTO_PAYLOADSIZE option should rather be "partially removed" - that is, it can still be set to some smaller value and may stay there for backward compat, but it will be deprecated and will be only partially regarded. This option should be maintained internally and for measurement it should:

  • start from 0
  • set EQUAL to the incoming report value when the current value is 0 (this will never happen again during transmission)
  • otherwise add a brick for IIR average measurement

@ethouris ethouris added Priority: Medium Status: Pending Type: Maintenance Work required to maintain or clean up the code labels Sep 19, 2019
@maxsharabayko maxsharabayko modified the milestones: v1.4.1, v1.4.2 Nov 11, 2019
@maxsharabayko maxsharabayko self-assigned this Dec 27, 2019
@maxsharabayko maxsharabayko mentioned this issue Feb 6, 2020
Closed
@ethouris ethouris linked a pull request Feb 13, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxsharabayko maxsharabayko

Labels
[core] Area: Changes in SRT library core Priority: Medium Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
Major
Development

Successfully merging a pull request may close this issue.

Removed payload size dependency and option ethouris/srt
2 participants
@ethouris @maxsharabayko