Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wooden buckets don't fill Water Pads #432

Closed
McFrugal opened this issue May 25, 2016 · 10 comments
Closed

Wooden buckets don't fill Water Pads #432

McFrugal opened this issue May 25, 2016 · 10 comments

Comments

@McFrugal
Copy link

Agricraft water pads (where you right-click with a shovel on farmland) don't like wooden buckets and instead you get a block of water on top of the water pad, which then most likely floods your farm (ugh).

As a side note, I noticed that if you put down water with a wooden bucket when there's already water (flowing or not) there, you get a "pop" sound effect and some particles as if you destroyed the water. Maybe that has something to do with this? Or maybe Agricraft is just picky.

@DarkGuardsman
Copy link

I'll look into both of these issues, the first is most likely Agricraft using custom interaction. The other, if I recall right, may be intentional so buckets can be emptied quickly to use for other fluids.

@McFrugal
Copy link
Author

With normal buckets, there's no pop or particles. That's the only issue, so... Oh, sorry, I guess I was unclear. The water block IS placed if it's just flowing water. It just sounds and looks like you're "breaking" the flowing water, or the source block if there was one there.

@DarkGuardsman
Copy link

Oh I see what you mean, not sure why it is doing the block place particle effects. Though to be honest is rather nice but I can see about adding a config to disable it.

@DarkGuardsman
Copy link

@Haggle1996
Copy link
Owner

I was confused too.

@DarkGuardsman
Copy link

You can most likely close this, I fixed the particle effect issue. Not sure why the vanilla bucket doesn't do the same effect considering it calls the same code.

@Haggle1996
Copy link
Owner

Thanks much, @DarkGuardsman

@dmodoomsirius
Copy link

new build is now live on curse. :)

@Haggle1996
Copy link
Owner

Awesome! Thank you again so much!

@dmodoomsirius
Copy link

sorry it took me so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants