Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Roles #413

Open
ashayp22 opened this issue Jan 14, 2022 · 0 comments
Open

Refactor Roles #413

ashayp22 opened this issue Jan 14, 2022 · 0 comments
Labels
bug

Comments

@ashayp22
Copy link
Contributor

ashayp22 commented Jan 14, 2022 •
edited
Loading

  • HIApplicationStateController.isGuest is badly named since isGuest is set to true if the user is a guest AND a staff member. Change the name to something better, like isGuestOrStaff?
  • Why are there so many Role structs? We should look into any Role or Attendee structs or variables that are badly named or are no longer being used.
  • For the test account that we use, the API returns the Attendee, Staff, Applicant, and User role. Why is this happening? Was happening because the test account has both the Staff and User role. No other accounts should have this.
@ashayp22 ashayp22 added the bug label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashayp22