Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If "DetrTransformerDecoderLayer" has been used in mapqr, is the "self_attn_mask" for one2many strategy works in self attention module? #12

Closed
TommyAnqi opened this issue Sep 12, 2024 · 2 comments
Closed

If "DetrTransformerDecoderLayer" has been used in mapqr, is the "self_attn_mask" for one2many strategy works in self attention module? #12

TommyAnqi opened this issue Sep 12, 2024 · 2 comments

Comments

@TommyAnqi
Copy link

No description provided.

@fishmarch
Copy link
Contributor

Thanks for pointing out this bug. I did not notice this before, I will further check and fix this recently. The performance should be better after fixing this bug.

@fishmarch fishmarch reopened this Sep 13, 2024
@fishmarch
Copy link
Contributor

I upload a version to fix this bug. But I get similar perfomance with this attn_mask, it gets mAP1 = 42.9 and mAP2 = 66.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TommyAnqi @fishmarch