Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the vc.type elements in the examples being generated properly? #206

Open
jdkizer9 opened this issue Jan 5, 2022 · 2 comments
Open

Comments

@jdkizer9
Copy link

jdkizer9 commented Jan 5, 2022

Scenario 1 bundle (COVID-19 immunization) expanded JWS includes the following type:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#labresult"
    ],

I'd expect this to be:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#immunization",
      "https://smarthealth.cards#covid19"
    ],

Scenario 3 bundle (COVID-19 lab result) expanded JWS includes the same type element as above. I'd expect it to be:

"type": [
      "https://smarthealth.cards#health-card",
      "https://smarthealth.cards#labresult",
      "https://smarthealth.cards#covid19"
    ],
@nkarip
Copy link
Collaborator

nkarip commented Jan 5, 2022

Yes, main branch is not correct. We have a fix pending in the dev branch at https://github.com/HL7/fhir-shc-vaccination-ig/tree/dev/examples but this has not yet promoted to main.

@p9g
Copy link
Collaborator

p9g commented Jan 5, 2022

See #174 and #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants