Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing preflight publication check #952

Open
jkiddo opened this issue Aug 30, 2024 · 5 comments
Open

Missing preflight publication check #952

jkiddo opened this issue Aug 30, 2024 · 5 comments
Labels
Approved Change has been reviewed and accepted and can now be applied to the templates enhancement New feature or request

Comments

@jkiddo
Copy link
Contributor

jkiddo commented Aug 30, 2024

The website.url in the publication-request.json may not shade across the destinations.

if it does the publisher acts in mysterious ways

  • add to that - ... it works fine for the first publication ... but once you are doing your second publication it starts acting up

also stated on https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Second.20publication.20goes.20bad.20.2E.2E.2E.20.3A.28

@lmckenzi
Copy link
Contributor

@jkiddo To confirm, the issue is that website.url is defining a 'root' url, but you may have destinations in your publication file that are not proper descendants of that 'root' url -and if that happens, the publisher doesn't behave properly. And you're advocating that the publisher should check that all destinations are in fact proper descendants of the root url. Is that explanation correct?

@jkiddo
Copy link
Contributor Author

jkiddo commented Sep 11, 2024

The destinations should be relative (adding) to the root url at all times. Current behaviour is inconsistent as it seems to be a mix of both relative ( destinations) and fixed ( root ). If the root is x.y.z and the destination is 'z', then the clean end result should be x.y.z.z - or it should fail fast. Right now it fails very late in the process.

@jkiddo
Copy link
Contributor Author

jkiddo commented Sep 11, 2024

To be clear: I dont want x.y.z.z. I wanted an error saying that 'z' was shading over the root url as it was x.y.z where it should have been just x.y - and I would prefer to have that error early.

@lmckenzi lmckenzi added enhancement New feature or request Approved Change has been reviewed and accepted and can now be applied to the templates labels Sep 17, 2024
@lmckenzi
Copy link
Contributor

We should be spitting out a warning or error if the canonical is not the same as the url + destination.

@jkiddo
Copy link
Contributor Author

jkiddo commented Sep 18, 2024

On this one I would prefer a fail-fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Change has been reviewed and accepted and can now be applied to the templates enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants