Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ig-publisher strictness on package-list.json #286

Closed
JohnMoehrke opened this issue Jun 18, 2021 · 2 comments
Closed

ig-publisher strictness on package-list.json #286

JohnMoehrke opened this issue Jun 18, 2021 · 2 comments
Labels
Approved Change has been reviewed and accepted and can now be applied to the templates enhancement New feature or request

Comments

@JohnMoehrke
Copy link
Contributor

I didn't understand till today that the package-list.json needs to be strictly json. I had extra spaces prior to the ':'. I didn't learn this until the second release, and only looking at the qa results. Could this be detected sooner? Could this throw an error, rather than just a note in the qa report (the note is a good note, but didn't pop out at me as a problem).

@lmckenzi lmckenzi added the NeedGrahame Need Grahame for discussion label Jun 21, 2022
@lmckenzi lmckenzi added enhancement New feature or request Approved Change has been reviewed and accepted and can now be applied to the templates and removed NeedGrahame Need Grahame for discussion labels Aug 2, 2022
@lmckenzi
Copy link
Contributor

@JohnMoehrke to verify if this is still happening with publication-request.json.

@JohnMoehrke
Copy link
Contributor Author

publication-request.json works with both a leading space before: and not. (also works with no trailing space after the :.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Change has been reviewed and accepted and can now be applied to the templates enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants