Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant sorting #480

Open
ajmani2195 opened this issue Dec 17, 2024 · 0 comments
Open

Redundant sorting #480

ajmani2195 opened this issue Dec 17, 2024 · 0 comments

Comments

@ajmani2195
Copy link

all_text_units, key=lambda x: (x["order"], -x["relation_counts"])

key=lambda x: (x["order"], -x["relation_counts"])

The sorting will never consider relations_count as 'order' value is derived from an incremental index. Shouldn't it be

key=lambda x: (-x["relation_counts"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant