Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dqn... files to use functions #24

Open
Jmiceli17 opened this issue Dec 29, 2023 · 0 comments
Open

Update all dqn... files to use functions #24

Jmiceli17 opened this issue Dec 29, 2023 · 0 comments
Labels
enhancement New feature or request general

Comments

@Jmiceli17
Copy link
Member

Most dqn-....py files in this repo are set up like scripts, they call main once at the beginning and then just step through the file. This is bad practice and looks messy. It'd be nice to put the actual training and logging in functions or something just to improve readability. It'd also make it easier to implement new methods because code would me more reusable.

@Jmiceli17 Jmiceli17 added enhancement New feature or request general labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request general
Projects
None yet
Development

No branches or pull requests

1 participant