Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add Linters and Testers to Pre Commit #429

Closed
2 tasks
acouch opened this issue Aug 29, 2023 · 1 comment
Closed
2 tasks

[Task]: Add Linters and Testers to Pre Commit #429

acouch opened this issue Aug 29, 2023 · 1 comment
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@acouch
Copy link
Collaborator

acouch commented Aug 29, 2023

Summary

Pre-commit has been added to the project. The api, frontend, and infra components have since been added to the project. Each of these has a linter (infra's can be re-introduced) and tests that can be added to pre-commit so that tests and lints for specific file types can be run before committing.

This will save time, for both committers and code reviewers, as changes won't be introduced before linters and tests have been run and is widely adopted as a best practice.

Acceptance criteria

  • linters and tests have been added to pre-commit
  • documentation is updated
@daphnegold
Copy link
Contributor

Duplicate of #223

@daphnegold daphnegold marked this as a duplicate of #223 Sep 18, 2023
@daphnegold daphnegold reopened this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Development

No branches or pull requests

2 participants