Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Investigate and set up frontend pre-commit hooks for prettier, eslint, ts checks #1262

Open
rylew1 opened this issue Feb 16, 2024 · 1 comment

Comments

@rylew1
Copy link
Contributor

rylew1 commented Feb 16, 2024

Summary

Create frontend pre-commit hooks for prettier, eslint, ts checks

  • Investigate setting up with husky, lintstaged, and .lintstagedrc.js file from previous projects

Acceptance criteria

Commits are prettified, ts checked, and eslinted

Notes

  • Suggestion: Add in the nava template, separate ticket to bring it in later from the API
  • Ability to opt out with git commit --no-verify
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label Feb 16, 2024
@rylew1 rylew1 added this to the Technical improvements milestone Feb 16, 2024
@rylew1 rylew1 changed the title [Task]: Create frontend pre-commit hooks for prettier, eslint, ts checks [Task]: Investigate setting up frontend pre-commit hooks for prettier, eslint, ts checks Feb 16, 2024
@acouch
Copy link
Collaborator

acouch commented Feb 16, 2024

We had identified this for front and backend but not moved forward with it #223 . Thanks for addressing. Let's discuss in refinement the LOE in just adding pre-commit hooks for what is already there vs adding husky etc. It could be two tasks.

@sumiat sumiat changed the title [Task]: Investigate setting up frontend pre-commit hooks for prettier, eslint, ts checks [Task]: Investigate and set up frontend pre-commit hooks for prettier, eslint, ts checks Feb 27, 2024
@margaretspring margaretspring removed this from the Technical improvements - Cross-Deliverables milestone Oct 22, 2024
@mxk0 mxk0 removed project: grants.gov Grants.gov Modernization tickets refinement labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants