Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Front-end Repo Setup #110

Closed
14 of 17 tasks
Tracked by #50
widal001 opened this issue Jun 30, 2023 · 2 comments · Fixed by #283
Closed
14 of 17 tasks
Tracked by #50

[Task]: Front-end Repo Setup #110

widal001 opened this issue Jun 30, 2023 · 2 comments · Fixed by #283
Assignees
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@widal001
Copy link
Collaborator

widal001 commented Jun 30, 2023

Summary

Set up the front-end portion of the repository with the language decided in #96 and the set of code quality tools selected in #102

User Stories

  • As an open source contributor, I want to:
    • be able to reference documentation explaining how to use the developer tools, so that I don't have to learn how to use these tools on my own in order to contribute to the project
    • have full test coverage for the codebase, so that I know when I've introduce code that changes or breaks existing behavior
    • have code formatting and standards enforced with automated tooling, so that I don't have to learn and check that my code adheres to those standards manually
  • As a maintainer of the project, I want to:
    • have code quality checks run automatically on each push, so that formatting, linting, or security issues are caught before being deployed to production
    • ensure that new contributions meet certain thresholds for test coverage, so that code contributions from internal and external developers also include tests which validate the code's behavior

Acceptance Criteria

  • A frontend/ sub-directory has been created with a README that includes instructions for how to install and run the code in this sub-directory
  • At least 2 dependencies have been added to the project, and the dependency manager selected in [ADR]: Front-end Code Quality Tools #102 automatically checks for dependency conflicts and offers suggestions for how to reconcile those conflicts:
  • A dummy test has been created (i.e. assert True) that users can execute to verify they've installed the project correctly
  • The following checks are run before every commit:
    • Auto-formatting
    • Linting (basic)
    • Type checks (optional)
    • [ ] Commit formatting (preferably conventional commit)
  • The following checks are run with each push to the remote GitHub repo, and these checks are run against all minor versions of the backend language we plan to support:
    • Auto-formatting
    • Linting (complete)
    • Type checks
    • Dependency vulnerability checks
    • Open source license checks
    • Unit tests
    • Test coverage
  • A PR is blocked from merging if any of the checks above fail
  • At least 2 people who did not contribute to this PR have installed and run the dummy test locally

Proposed Testing Strategy

  1. Unit tests: Create a test_sample test that simply asserts true or asserts the version number
  2. Manual Tests: Someone who did not contribute to the PR checks out the PR locally, follows the instructions in the README to install the code, run the tests and the code quality checks locally, and all checks/tests pass.
@widal001 widal001 changed the title [Task]: Frontend repo setup [Task]: Frontend Repo Setup Jun 30, 2023
@widal001 widal001 moved this to Sprint Backlog in Simpler.Grants.gov Product Backlog Jun 30, 2023
@widal001 widal001 added this to the Developer Tools milestone Jul 3, 2023
@acouch
Copy link
Collaborator

acouch commented Jul 7, 2023

We have the opportunity to utitlize a NextJS template focused on federal level clients. Some of the features and benefits of this template is:

  • This is a Next.js React web application, written in TypeScript.
  • U.S. Web Design System provides themeable styling and a set of common components.
  • React-USWDS provides React components already with USWDS theming out of the box. For a reference point starting out, see react-uswds-hello.tsx which includes examples of react-uswds component usage.
  • Storybook is included as a frontend workshop.

@acouch acouch changed the title [Task]: Frontend Repo Setup [Task]: Front-end Repo Setup Jul 10, 2023
@sumiat sumiat moved this from Sprint Backlog to Backlog in Simpler.Grants.gov Product Backlog Jul 12, 2023
@sumiat sumiat moved this from Backlog to Sprint Backlog in Simpler.Grants.gov Product Backlog Jul 12, 2023
@widal001 widal001 added the project: grants.gov Grants.gov Modernization tickets label Jul 14, 2023
@SammySteiner SammySteiner moved this from Sprint Backlog to In Progress in Simpler.Grants.gov Product Backlog Jul 18, 2023
@SammySteiner
Copy link
Contributor

Moving commit formatting and license check to other tickets:
#223
#292

Noting that when we add infrastructure setup via terraform, we'll include a github workflow that uses the grype file for dependency vulnerability checking in the ci/cd pipeline.

@SammySteiner SammySteiner moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog Jul 19, 2023
acouch pushed a commit that referenced this issue Sep 18, 2024
Fixes #110

* added info level logging statement to the `db_import` command

_Terminal_
<img width="1446" alt="Screen Shot 2024-07-01 at 4 35 44 PM"
src="https://github.com/navapbc/simpler-grants-gov/assets/37313082/4f1ddf6c-5ae5-45d6-8bc9-229ff47e6b4b">

_Database_
<img width="1148" alt="Screen Shot 2024-07-01 at 4 35 56 PM"
src="https://github.com/navapbc/simpler-grants-gov/assets/37313082/99ac5d11-6073-42b2-bffe-32dff78e75f4">

> Screenshots, GIF demos, code examples or output to help show the
changes working as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Development

Successfully merging a pull request may close this issue.

3 participants