Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target level cap - larger or equal config checks (v3) #373

Open
siraaris opened this issue Nov 5, 2024 · 1 comment
Open

Target level cap - larger or equal config checks (v3) #373

siraaris opened this issue Nov 5, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@siraaris
Copy link

siraaris commented Nov 5, 2024

Checks for target_level in config and UI note that:

target_level can't be larger than X (when target_level is set to X).

Screenshot 2024-11-06 at 6 04 08 am

A similar note is given in src/config.rs:

if conf.devices.target_level() >= target_level_limit {
    let msg = format!("target_level can't be larger than {}", target_level_limit);
    return Err(ConfigError::new(&msg).into());

Maybe the check should be > or the message updated to say larger or equal to...

@HEnquist
Copy link
Owner

HEnquist commented Nov 9, 2024

Thanks! Fixed in the next30 branches of camilladsp and pycamilladsp-plot.

@HEnquist HEnquist added this to the 3.0 milestone Nov 9, 2024
@HEnquist HEnquist added the bug Something isn't working label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants