Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest #116

Merged
merged 12 commits into from
May 5, 2021
Merged

Fix pytest #116

merged 12 commits into from
May 5, 2021

Conversation

aewallwi
Copy link
Collaborator

@aewallwi aewallwi commented May 1, 2021

Fix lingering issues in pytest migration that are hindering proper coverage recording and codecov checks. Verbatum translation of existing unittests into pytest compatible tests. Issues of organization of the existing tests addressed in #117.

@aewallwi aewallwi requested a review from r-pascua May 1, 2021 02:09
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #116 (ae90d9d) into main (e6075ad) will increase coverage by 48.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #116       +/-   ##
===========================================
+ Coverage   38.04%   86.84%   +48.80%     
===========================================
  Files          10        7        -3     
  Lines        2363     1460      -903     
===========================================
+ Hits          899     1268      +369     
+ Misses       1464      192     -1272     
Flag Coverage Δ
unittests 86.84% <ø> (+48.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
uvtools/plot.py 72.80% <0.00%> (+72.80%) ⬆️
uvtools/version.py 79.62% <0.00%> (+79.62%) ⬆️
uvtools/dspec.py 96.41% <0.00%> (+96.41%) ⬆️
uvtools/utils.py 97.05% <0.00%> (+97.05%) ⬆️
uvtools/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
uvtools/data/__init__.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6075ad...ae90d9d. Read the comment docs.

Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the coverage is working and that all the tests are passing. Since we're not worrying about modularizing tests in this PR, I'm happy to approve as-is. I think that now the tests for the plotting tools I wrote are kind of wonky, but I'll get to that in a future PR.

Thank you for doing this!

@r-pascua r-pascua merged commit 01d0e32 into main May 5, 2021
@r-pascua r-pascua deleted the fix_pytest branch May 5, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants