-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pytest #116
Fix pytest #116
Conversation
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
===========================================
+ Coverage 38.04% 86.84% +48.80%
===========================================
Files 10 7 -3
Lines 2363 1460 -903
===========================================
+ Hits 899 1268 +369
+ Misses 1464 192 -1272
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the coverage is working and that all the tests are passing. Since we're not worrying about modularizing tests in this PR, I'm happy to approve as-is. I think that now the tests for the plotting tools I wrote are kind of wonky, but I'll get to that in a future PR.
Thank you for doing this!
Fix lingering issues in pytest migration that are hindering proper coverage recording and codecov checks. Verbatum translation of existing unittests into pytest compatible tests. Issues of organization of the existing tests addressed in #117.