Allow weights to be set externally in tophat_frfilter #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what the documentation said, wgts were always ~self.flags, regardless of what was passed in.
Codecov Report
@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 19 19
Lines 7598 7599 +1
=======================================
+ Hits 7358 7359 +1
Misses 240 240
Continue to review full report at Codecov.
|
|
This was addressed in #736, so I'm closing this in favor of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what the documentation said, wgts were always ~self.flags, regardless of what was passed in.