Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 3.3: Test of xRFI #41

Open
steven-murray opened this issue Oct 21, 2019 · 5 comments
Open

Step 3.3: Test of xRFI #41

steven-murray opened this issue Oct 21, 2019 · 5 comments
Assignees
Labels
formal-test A formal Validation Test pipeline:pspec Tests the pspec pipeline component pipeline:redcal Tests the redcal pipeline component pipeline:smoothcal Tests the smoothcal pipeline component pipeline:xrfi Tests the xRFI pipeline component simcmp:eor:powerlaw Uses a power-law P(k) for EoR signal simcmp:fg:gleam Simulation Component: GLEAM simcmp:fg:gsm Simulator Component: Global Sky Model simcmp:sys:gains Simulation Component: Gains simcmp:sys:rfi Simulation Component: RFI simulator:hera_sim Uses the hera_sim simulator simulator:rimez Uses the RIMEz simulator status:active A formal test that is being actively worked on

Comments

@steven-murray
Copy link
Contributor

This test is the first explicit test of xRFI. The idea is to use hera_sim to add RFI to a fiducial simulation including EoR and FG, and then use xRFI to flag it, and then use pspec to determine a power spectrum after flagging.

  • Simulation Component: GSM, GLEAM, EoR (powerlaw), gains, RFI
  • Simulators: hera_sim, RIMEz
  • Pipeline Components: redcal, smoothcal, xRFI, pspec`
  • Depends on: Step 2.1 #16

Why this test is required

#21 and #22 check the performance of pspec with realistic flags (more realistic than this will generate), thus this is not a particularly good test of how pspec deals with flags. What it adds is two things: 1) how well xRFI does in terms of accuracy of removing RFI, and 2) how much the inaccuracy propagates through to the power spectrum.

Summary

A brief step-by-step description of the proposed test follows:

  • Obtain FG and EoR visibilities in the same way as Step 2.1 #16.
  • Add gains in the same way as Step 2.1 #16.
  • Use hera_sim.add_rfi to add RFI visibilities (and save pure-RFI visibilities as well)
  • Run redcal and smoothcal.
  • Run xRFI
  • Look at accuracy of xRFI
  • Run @nkern's post-processing and in-painting.
  • Run pspec

Simulation Details

  • Freq. range:
  • Channel width:
  • Baseline/antenna configuration:
  • Total integration time:
  • Number of realisations:

Criteria for Success

  • P(k) matches known input to within 1%
@steven-murray steven-murray added the formal-test A formal Validation Test label Oct 21, 2019
@steven-murray steven-murray added pipeline:pspec Tests the pspec pipeline component pipeline:redcal Tests the redcal pipeline component pipeline:smoothcal Tests the smoothcal pipeline component pipeline:xrfi Tests the xRFI pipeline component simcmp:eor:powerlaw Uses a power-law P(k) for EoR signal simcmp:fg:gleam Simulation Component: GLEAM simcmp:fg:gsm Simulator Component: Global Sky Model simcmp:sys:gains Simulation Component: Gains simcmp:sys:rfi Simulation Component: RFI simulator:hera_sim Uses the hera_sim simulator simulator:rimez Uses the RIMEz simulator labels Oct 21, 2019
@steven-murray steven-murray added this to the H1C IDR2 milestone Oct 21, 2019
@steven-murray steven-murray added the status:active A formal test that is being actively worked on label Oct 28, 2019
@r-pascua
Copy link
Collaborator

r-pascua commented Nov 4, 2019

@lwhitler to chat with @adampbeardsley to figure out how to fix bug with xrfi (xrfi has no check attribute) and to determine proper use of noise--does xrfi expect a realistic level of noise, or does it just need enough noise to have finite chi-squared values?

@adampbeardsley
Copy link
Member

What do you mean check attribute?

xrfi uses the noise to quantify the outlier-ness of data points. Having no noise will result in divisions by zero. Have unrealistic noise will result in unrealistic flagging. But if you abstract the performance in terms of SNR, I suppose any level should be ok. Of course the detrending of the actual signal isn't going to be perfect, so there will be some mutual coupling between noise and signal level, but I think that's second order.

@r-pascua
Copy link
Collaborator

r-pascua commented Nov 4, 2019

@lwhitler can you post a screenshot of the error you showed in the telecon?

@lwhitler
Copy link

lwhitler commented Nov 4, 2019

@adampbeardsley

If run_check=True in xrfi.xrfi_run(), this happens:
image

And run_check=False is a different error:
image

@adampbeardsley
Copy link
Member

Ah, this is an pyuvdata version issue. If you update pyuvdata (may need to do so from source, I'm not sure if it's in a release yet), you should be good to go.

@steven-murray steven-murray removed this from the H1C IDR2 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formal-test A formal Validation Test pipeline:pspec Tests the pspec pipeline component pipeline:redcal Tests the redcal pipeline component pipeline:smoothcal Tests the smoothcal pipeline component pipeline:xrfi Tests the xRFI pipeline component simcmp:eor:powerlaw Uses a power-law P(k) for EoR signal simcmp:fg:gleam Simulation Component: GLEAM simcmp:fg:gsm Simulator Component: Global Sky Model simcmp:sys:gains Simulation Component: Gains simcmp:sys:rfi Simulation Component: RFI simulator:hera_sim Uses the hera_sim simulator simulator:rimez Uses the RIMEz simulator status:active A formal test that is being actively worked on
Projects
None yet
Development

No branches or pull requests

4 participants