Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library needs refactoring #57

Open
clelange opened this issue Jul 31, 2018 · 1 comment
Open

library needs refactoring #57

clelange opened this issue Jul 31, 2018 · 1 comment
Labels
code style/structure Anything related to what the code looks like rather than what it does.

Comments

@clelange
Copy link
Collaborator

The library has reached > 1000 lines and pylint is complaining, so we should move some of the classes into separated files and then enable too-many-lines (d9ed87f).
@AndreasAlbert
Copy link
Collaborator

There are some obvious candidates:

  • Refactor into something like helpers.py: execute_command, find_all_matching, relative_round, check_file_existence, check_file_size

  • Refactor into something like RootInteraction.py: RootFileReader, get_graph_points, get_hist_1d_points, get_hist_2d_points

@AndreasAlbert AndreasAlbert added the code style/structure Anything related to what the code looks like rather than what it does. label Aug 1, 2018
@AndreasAlbert AndreasAlbert mentioned this issue Aug 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style/structure Anything related to what the code looks like rather than what it does.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clelange @AndreasAlbert