Skip to content
This repository has been archived by the owner on Mar 12, 2019. It is now read-only.

Separate FM and xdaq from MASKED_RESOURCES #295

Open
kakwok opened this issue Jun 23, 2017 · 2 comments
Open

Separate FM and xdaq from MASKED_RESOURCES #295

kakwok opened this issue Jun 23, 2017 · 2 comments

Comments

@kakwok
Copy link
Collaborator

kakwok commented Jun 23, 2017

Currently, we put FM and xdaq into the same FM parameter: MASKED_RESOURCES, but it is not easy to distinguish FM/xdaq after being mixed up in the parameter afterwards. e.g. Masked FMs should not enter StripExecXml().
It's better to separate the them into different FM parameters.

@jhakala
Copy link
Member

jhakala commented Jun 23, 2017

One might consider as an alternative making the MASKED_RESOURCES into a more complicated structure, e.g. a MapT<VectorT<StringT>> where we fill the different types of masked resources into a structure like

{"maskedFMs" : ["Level2_HBHEa","Level2_HBHEb"], 
"maskedApps":["hcalSupervisor_0","hcalSupervisor_1"], 
"maskedExecs": ["Executive_0"]}

Also, as it is, the MASK_SUMMARY is basically a list of masked FMs.

I would also note that this is a complicated optimization to do since it requires careful checks of the logic on both the server and GUI sides, and it buys us very little.

@jhakala
Copy link
Member

jhakala commented Apr 18, 2018

See related discussion at #404.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants