Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving pickle fails if git is not available #65

Open
ivvv opened this issue Apr 8, 2019 · 0 comments
Open

Saving pickle fails if git is not available #65

ivvv opened this issue Apr 8, 2019 · 0 comments

Comments

@ivvv
Copy link

ivvv commented Apr 8, 2019

In the io.py module, when saving the posteriors and priors the code needs git_version() which calls git. If the command fails then an exception is raised.

This is inconvenient when e.g. sending an XID+ run on a grid, where the grid nodes do not necessarily have git installed. We tested and adjusted the XID+ script on a desktop where it was available, so there was no warning or anything. And as a result, when we run the actual processing on a grid, it failed with an exception after 50 hours. Not very helpful.

Ideally git_version() should not raise an exception but simply assign an unknown version (or something similar) with a warning of a possible mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant