Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Enough Stacks Will Probably Start To Have Span Data Missing #31

Open
Grunet opened this issue May 4, 2022 · 2 comments
Open

Large Enough Stacks Will Probably Start To Have Span Data Missing #31

Grunet opened this issue May 4, 2022 · 2 comments

Comments

@Grunet
Copy link
Owner

Grunet commented May 4, 2022

This is coming from the code not currently handling pagination of the AWS JS SDK calls at all (it's just making one call and calling that good).

This AWS doc about when pagination starts suggests its around when the response gets to 1 MB. When I measured the hollow-nesting-only (root) stack it came out to about 4000 bytes per deploy, which implies that it's roughly when a stack is 250 times as big (so like 250 resources) when problems would start to appear

@Grunet
Copy link
Owner Author

Grunet commented May 4, 2022

I think the code changes for this are straightforward, just actually making a large enough stack to end-to-end test it felt a little daunting when I thought about this before

@Grunet
Copy link
Owner Author

Grunet commented May 9, 2022

It seems like Cloudformation has a limit of 500 resources per stack? Per this - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant