Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ella): removed typedoc warnings coming in build #239

Closed
wants to merge 1 commit into from

Conversation

yash201040
Copy link
Mannequin

@yash201040 yash201040 mannequin commented Apr 18, 2023

What does this PR do?

Removes all type-doc warnings encountered while building package ella by improving re-exporting.
This PR resolves #240

What packages have been affected by this PR?

ella

Types of changes

Before:
image
After:
image

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Package version increase in any of the packages?

No

Checklist before merging

Put an x in the boxes that apply

  • These changes have been thoroughly tested.

  • Changes need to be immediately published on npm.

@@ -5,7 +5,8 @@
"./src/general/index.ts",
"./src/jsx/index.tsx",
"./src/number/index.ts",
"./src/string/index.ts"
"./src/string/index.ts",
"./src/utils/index.ts"
Copy link
Mannequin Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main changes which removed most warnings is this.

@yash201040
Copy link
Mannequin Author

yash201040 mannequin commented Apr 18, 2023

Maintainers can we merge this? @vikaz-singh @ristri

AdityaVandan
AdityaVandan mannequin approved these changes Apr 19, 2023
@yash201040 yash201040 mannequin closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings while building ella package
3 participants