From 8c86c5bfb232ebc2cef5609d13de115ae19b38a0 Mon Sep 17 00:00:00 2001 From: Abhishek Jha <07abhishekrock@gmail.com> Date: Fri, 2 Dec 2022 19:16:26 +0530 Subject: [PATCH 1/4] limited dom-prop injection to only the valid ones --- .../src/components/atoms/Accordion/Accordion.tsx | 3 ++- .../atoms/Accordion/AnimateHeight/AnimateHeight.tsx | 1 + .../Accordion/AnimateHeight/animateHeightUtils.ts | 12 +++++++++++- .../components/atoms/NumberInput/BaseNumberInput.tsx | 4 +++- 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx b/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx index 4be6e34b..9cf7707f 100644 --- a/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx +++ b/packages/ui-toolkit/src/components/atoms/Accordion/Accordion.tsx @@ -156,7 +156,8 @@ const MutableAccordion = (props: Props) => { :
{ className={componentClasses} style={componentStyle} > + {JSON.stringify(omit(this.props, ...PROPS_TO_OMIT))}
((pr min={min} onKeyDown={_onKeyDown} type="number" - {...rest} + disabled={rest.disabled} + value={rest.value} + variant={rest.variant} onChange={_onChange} ref={ref} /> From 67c8312d6ec1b14b52d97275a76d8d3902ba3b85 Mon Sep 17 00:00:00 2001 From: Abhishek Jha <07abhishekrock@gmail.com> Date: Sat, 3 Dec 2022 20:14:45 +0530 Subject: [PATCH 2/4] removed console.log --- .../components/atoms/Accordion/AnimateHeight/AnimateHeight.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/AnimateHeight.tsx b/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/AnimateHeight.tsx index 3cdad223..391b08e8 100644 --- a/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/AnimateHeight.tsx +++ b/packages/ui-toolkit/src/components/atoms/Accordion/AnimateHeight/AnimateHeight.tsx @@ -321,7 +321,6 @@ class AnimateHeight extends React.Component { className={componentClasses} style={componentStyle} > - {JSON.stringify(omit(this.props, ...PROPS_TO_OMIT))}
Date: Tue, 3 Jan 2023 12:43:48 +0530 Subject: [PATCH 3/4] reverted changes for BaseNumberInput --- .../src/components/atoms/NumberInput/BaseNumberInput.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/ui-toolkit/src/components/atoms/NumberInput/BaseNumberInput.tsx b/packages/ui-toolkit/src/components/atoms/NumberInput/BaseNumberInput.tsx index 4da7f1c8..09488d40 100644 --- a/packages/ui-toolkit/src/components/atoms/NumberInput/BaseNumberInput.tsx +++ b/packages/ui-toolkit/src/components/atoms/NumberInput/BaseNumberInput.tsx @@ -86,9 +86,7 @@ const BaseNumberInput = React.forwardRef((pr min={min} onKeyDown={_onKeyDown} type="number" - disabled={rest.disabled} - value={rest.value} - variant={rest.variant} + {...rest} onChange={_onChange} ref={ref} /> From 1acb115142824edf9f14fe65164dc012e533918d Mon Sep 17 00:00:00 2001 From: Abhishek Jha <07abhishekrock@gmail.com> Date: Wed, 15 Feb 2023 15:34:31 +0530 Subject: [PATCH 4/4] fixed invalid props --- packages/ui-toolkit/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-toolkit/package.json b/packages/ui-toolkit/package.json index b5623cc1..379258ce 100644 --- a/packages/ui-toolkit/package.json +++ b/packages/ui-toolkit/package.json @@ -1,6 +1,6 @@ { "name": "@groww-tech/ui-toolkit", - "version": "0.2.6", + "version": "0.2.7", "description": "A lightning nature UI", "main": "dist/cjs/index.js", "module": "dist/esm/index.js",