Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of cards #172

Open
atherdon opened this issue Jan 17, 2019 · 14 comments
Open

List of cards #172

atherdon opened this issue Jan 17, 2019 · 14 comments
Assignees

Comments

@atherdon
Copy link
Member

More details upon request.


At this project we have some cards, that AntD library can create.
After chat with Vadim we realized that mauwerk works slow, and it's better to replace it.
So we'll create a separated page, that will be similar to HomeView, but instead of Grid from mauwerk - we'll have component, with cards.

it's a big task, but i want to start it. Soon we plan to make visible some of our projects, and this task is part of this plan.
Let's start with small things:
separated component, connected to router, that can display few cards in loop.

@atherdon atherdon mentioned this issue Jan 17, 2019
4 tasks
@Avuidrauxs
Copy link
Contributor

@atherdon , Can I get more clarity on this and are we gonna use reusable components with cards?

@atherdon
Copy link
Member Author

first of all - did you finish my last assignment, related to reviewing all components with inline styles?

@Avuidrauxs
Copy link
Contributor

@atherdon , Not entirely I'm still combing through to be thorough

@atherdon
Copy link
Member Author

about your questions. you should: fork that project, take a look around and yes, I assume later we'll create this cards as separated repo.


let's start from small things:
did you find that cards and understand why we'll use them?

Can you tell me an exact step-by-step plan, how we'll complete this whole task?
give me your questions ;)

@atherdon
Copy link
Member Author

and still, let's finish a task with styles before. because I get feeling that you don't have a whole understanding of the structure of this project yet. and this is fine

@Avuidrauxs
Copy link
Contributor

@atherdon I am done with task regarding the inline styles in components , can you review

@atherdon
Copy link
Member Author

@Avuidrauxs reviewed and merged - thanks!

@Avuidrauxs
Copy link
Contributor

@atherdon , Okay now I understand what you want me to do , you want me to start simple and implement a component with antd cards right?

@Avuidrauxs
Copy link
Contributor

@atherdon , So should I use the recipe-antd in Chicken-kyiv as a guide or you have another design pattern you want me to use?

@atherdon
Copy link
Member Author

This cards related to displaying recipe-data.

I think Vadim update one of these cards. But in order to make cards-examples work also with grocery-data - i think we should have them separated. Hold on, i'll create a separated repo for you

@atherdon
Copy link
Member Author

at this repo we'll keep our card components: https://github.com/GroceriStar/cards-wrapper-component

in order to speed up development, i just copy-paste whole project from pdf-export-component that we also have at showcase...
check the structure and then feel free to delete all components and put cards inside.
this project has nice setup, with builds, etc. that will help us to publish and maintain a separated module

@atherdon
Copy link
Member Author

tell me if you 'll need my help in order to understand how it works. you can ask it at cards-wrapper repositories issues

@Avuidrauxs
Copy link
Contributor

@atherdon Okay , I would start now and let you see what I've done to make sure I'm on the right track. Thank you

@atherdon
Copy link
Member Author

perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants