Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master React, Quick Code tutorial. Part 7 #24

Open
3 of 7 tasks
atherdon opened this issue May 5, 2018 · 6 comments
Open
3 of 7 tasks

Master React, Quick Code tutorial. Part 7 #24

atherdon opened this issue May 5, 2018 · 6 comments
Assignees

Comments

@atherdon
Copy link
Member

atherdon commented May 5, 2018

https://medium.com/quick-code/lets-learn-react-chapter-7-component-life-cycle-6aaa815747db

Expected result

  • Read this tutorial chapter
  • follow code steps
  • move your code to this repository(at least one commit per day)
  • explain to me, what did you learn from it in a few sentences(not less than 5)
  • pass the test section
  • after reviewing your progress and closing this issue - you can move to the next chapter.

Test

  • by using componentWillMount add few recipes/meals. each item should have recipe_url, image, ingredient list(sub-array), directions(sub-array), description(string)
    simple thing #1
@smob123
Copy link
Collaborator

smob123 commented Jun 11, 2018

should I keep the steps and description?

@atherdon
Copy link
Member Author

i think yes, why are you asking? does we did something that will broke the code at current chapter?

@smob123
Copy link
Collaborator

smob123 commented Jun 12, 2018

I just thought that you wanted me to replace the current values with new ones

@smob123
Copy link
Collaborator

smob123 commented Jun 12, 2018

I'll get started on it ASAP

@atherdon
Copy link
Member Author

i think you just need to add a missing things. so if we didn't have a steps and description before - yep you should add it.
Not replace old code - just extend, as we're trying to learn more as we have in articles - maybe sometime we're overlapping things.

@smob123
Copy link
Collaborator

smob123 commented Jun 22, 2018

I just pushed some changes, I'm not sure if that's the correct way to do it though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants