Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar/src/components/RenderModal/RenderModal.js - connect our List component #99

Open
atherdon opened this issue Dec 17, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atherdon
Copy link
Member

replace current version of modal content with our list.
right now it's a title with map for ingredients inside

@atherdon atherdon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 17, 2018
@atherdon
Copy link
Member Author

right now we have a modal window with list of ingredients. i can crash a project right now - because i delete a previous component. so you should

  1. remove connection of deleted component
  2. check how we connect and use @groceristar/grocery-component sample are here
    and repository of this components are here

this is a video about how modal was looking before i delete a displayList component.

so our goal to fully replace a displayList component via our separated package.

feel free and ask questions about this task - it's not hard - but will show how we can collaborate with you together

@atherdon
Copy link
Member Author

replace current version of modal content with [our list].
Can you be a bit more specific about what you mean by our list?

first of all - I want you to dig into this task without a lot of help from my side.

another thing - in order to give you more details - you should be more specific too :)

back to your question - we have a modal window, and we have an ingredient list inside of it.
this list should be rendered by using @groceristar/grocery-component/Default or another component - that it's suitable for this case. I think you should fork and set up this project locally - then review code that we have at @groceristar/grocery-component repository.
you can also fork and check how we solve actually a 100% similar issue in showcase project.

so main goal of this task is not just fix this code - but give you an ability to spend some time and "swim" at our sandbox-projects

if you need more details - please ask detailed questions, like "how method A work in class B (url link to that code file at GitHub)". it give me the ability to reply to your question quicker. @dawitth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant