You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a bit contested in the Python community, but I am a big fan of mypy in particular. I find it makes code easier to read and maintain. Plus enforcing typehints means that types can be automatically included in the docstrings!
The text was updated successfully, but these errors were encountered:
I'm okay with stricter CI, our current setup was just quickly hacked together since I was short on time. I'm not exactly up to date on the state of the art with these kinds of tools, but if you would like to implement a few of them go for it! I don't think we need to do everything exactly like pymatgen, that's ultimately the whole point of the namespace package concept, but I think some level of homogeneity would be helpful for broader adoption.
Is there interest in including a greater variety of CI? For example, pymatgen's pre-commit config looks like this: https://github.com/materialsproject/pymatgen/blob/master/.pre-commit-config.yaml
It's a bit contested in the Python community, but I am a big fan of mypy in particular. I find it makes code easier to read and maintain. Plus enforcing typehints means that types can be automatically included in the docstrings!
The text was updated successfully, but these errors were encountered: