Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter CI? #19

Open
wolearyc opened this issue Oct 27, 2024 · 2 comments
Open

Stricter CI? #19

wolearyc opened this issue Oct 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@wolearyc
Copy link
Collaborator

Is there interest in including a greater variety of CI? For example, pymatgen's pre-commit config looks like this: https://github.com/materialsproject/pymatgen/blob/master/.pre-commit-config.yaml

It's a bit contested in the Python community, but I am a big fan of mypy in particular. I find it makes code easier to read and maintain. Plus enforcing typehints means that types can be automatically included in the docstrings!

@wolearyc wolearyc added the enhancement New feature or request label Oct 27, 2024
@oashour
Copy link
Collaborator

oashour commented Nov 23, 2024

I'm okay with stricter CI, our current setup was just quickly hacked together since I was short on time. I'm not exactly up to date on the state of the art with these kinds of tools, but if you would like to implement a few of them go for it! I don't think we need to do everything exactly like pymatgen, that's ultimately the whole point of the namespace package concept, but I think some level of homogeneity would be helpful for broader adoption.

@wolearyc
Copy link
Collaborator Author

All that makes sense. I'll add mypy for now and submit a PR once I've resolved most of the errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants