some edits

Author: nfarabullini

src/gt4py/cartesian/__init__.py

@@ -29,6 +29,7 @@
     stencil_object,
     type_hints,
 )
+from .stencil_object import StencilObject
 
 
 __all__ = [
@@ -44,5 +45,5 @@
     "stencil_builder",
     "stencil_object",
     "type_hints",
+    "StencilObject",
 ]
-from .stencil_object import StencilObject

src/gt4py/cartesian/backend/pyext_builder.py

@@ -195,7 +195,7 @@ def build_pybind_ext(
     libraries: Optional[List[str]] = None,
     extra_compile_args: Optional[Union[List[str], Dict[str, List[str]]]] = None,
     extra_link_args: Optional[List[str]] = None,
-    build_ext_class: Type = None,
+    build_ext_class: Optional[Type] = None,
     verbose: bool = False,
     clean: bool = False,
 ) -> Tuple[str, str]:
@@ -213,7 +213,7 @@ def build_pybind_ext(
     libraries: Optional[List[str]] = None,
     extra_compile_args: Optional[Union[List[str], Dict[str, List[str]]]] = None,
     extra_link_args: Optional[List[str]] = None,
-    build_ext_class: Type = None,
+    build_ext_class: Optional[Type] = None,
     verbose: bool = False,
     clean: bool = False,
 ) -> Tuple[str, str]:

src/gt4py/cartesian/frontend/nodes.py

@@ -322,15 +322,6 @@ class ScalarLiteral(Literal):
     loc = attribute(of=Location, optional=True)
 
 
-# @attribclass
-# class TupleLiteral(Node):
-#     items = attribute(of=TupleOf[Expr])
-#
-#     @property
-#     def length(self):
-#         return len(self.items)
-
-
 @attribclass
 class BuiltinLiteral(Literal):
     value = attribute(of=Builtin)
@@ -593,12 +584,6 @@ class Statement(Node):
     pass
 
 
-# @attribclass
-# class ExprStmt(Statement):
-#     expr = attribute(of=Expr)
-#     loc = attribute(of=Location, optional=True)
-
-
 class Decl(Statement):
     pass
 
@@ -722,9 +707,6 @@ def is_single_index(self) -> bool:
         return self.start.level == self.end.level and self.start.offset == self.end.offset - 1
 
     def disjoint_from(self, other: "AxisInterval") -> bool:
-        # This made-up constant must be larger than any LevelMarker.offset used
-        DOMAIN_SIZE: int = 1000
-
         def get_offset(bound: AxisBound) -> int:
             return (
                 0 + bound.offset if bound.level == LevelMarker.START else sys.maxsize + bound.offset

src/gt4py/cartesian/gtscript.py

@@ -674,14 +674,14 @@ def __getitem__(self, field_spec):
         data_dims = ()
 
         if isinstance(field_spec, str) or not isinstance(field_spec, collections.abc.Collection):
-            # Field[dtype]
+            # Field[dtype] # noqa: ERA001 # commented-out code
             dtype = field_spec
         elif _FieldDescriptorMaker._is_axes_spec(field_spec[0]):
-            # Field[axes, dtype]
+            # Field[axes, dtype] # noqa: ERA001 # commented-out code
             assert len(field_spec) == 2
             axes, dtype = field_spec
         elif len(field_spec) == 2 and not _FieldDescriptorMaker._is_axes_spec(field_spec[1]):
-            # Field[high_dimensional_dtype]
+            # Field[high_dimensional_dtype] # noqa: ERA001 # commented-out code
             dtype = field_spec
         else:
             raise ValueError("Invalid field type descriptor")

src/gt4py/cartesian/utils/attrib.py

@@ -223,7 +223,7 @@ def attribute(of, optional=False, **kwargs):
         attr_type_hint = of.type_hint
 
     elif isinstance(of, type):
-        # assert of in (bool, float, str, int, enum.Enum)
+        # assert of in (bool, float, str, int, enum.Enum) # noqa: ERA001 # commented-out code
         attr_validator = attr.validators.instance_of(of)
         attr_type_hint = of
 

src/gt4py/next/embedded/operators.py

@@ -42,8 +42,10 @@ class ScanOperator(EmbeddedOperator[_R, _P]):
     init: core_defs.Scalar | tuple[core_defs.Scalar | tuple, ...]
     axis: common.Dimension
 
-    def __call__(
-        self, *args: common.Field | core_defs.Scalar, **kwargs: common.Field | core_defs.Scalar
+    def __call__(  # type: ignore[override]
+        self,
+        *args: common.Field | core_defs.Scalar,
+        **kwargs: common.Field | core_defs.Scalar,  # type: ignore[override]
     ) -> common.Field:  # we cannot properly type annotate relative to self.fun
         scan_range = embedded_context.closure_column_range.get()
         assert self.axis == scan_range[0]

src/gt4py/next/iterator/transforms/inline_lambdas.py

@@ -80,7 +80,7 @@ def inline_lambda(  # noqa: C901  # see todo above
     expr = node.fun.expr
     if clashes:
         # TODO(tehrengruber): find a better way of generating new symbols in `name_map` that don't collide with each other. E.g. this must still work:
-        # (lambda arg, arg_: (lambda arg_: ...)(arg))(a, b)  # noqa: E800
+        # (lambda arg, arg_: (lambda arg_: ...)(arg))(a, b)  # noqa: ERA001
         name_map: dict[ir.SymRef, str] = {}
 
         def new_name(name):