removed left-over comments

Author: nfarabullini

src/gt4py/eve/datamodels/core.py

@@ -695,7 +695,7 @@ def asdict(
         ...     y: int
         >>> c = C(x=1, y=2)
         >>> assert asdict(c) == {"x": 1, "y": 2}
-    """  # sphinx.napoleon conventions confuse RST validator
+    """
     if not is_datamodel(instance) or isinstance(instance, type):
         raise TypeError(f"Invalid datamodel instance: '{instance}'.")
     return attrs.asdict(instance, value_serializer=value_serializer)
@@ -805,7 +805,7 @@ def concretize(
         overwrite_definition: If ``True``, a previous definition of the class in
             the target module will be overwritten.
 
-    """  # doctest conventions confuse RST validator
+    """
     concrete_cls: Type[DataModelT] = _make_concrete_with_cache(
         datamodel_cls,  # type: ignore[arg-type]
         *type_args,
@@ -1022,7 +1022,7 @@ def _type_converter(value: Any) -> _T:
 _KNOWN_MUTABLE_TYPES: Final = (list, dict, set)
 
 
-def _make_datamodel(  # too complex but still readable and documented
+def _make_datamodel(
     cls: Type[_T],
     *,
     repr: bool,  # noqa: A002   # shadowing 'repr' python builtin

src/gt4py/eve/extended_typing.py

@@ -180,11 +180,9 @@ def __get__(
     ) -> NonDataDescriptor[_C, _V]: ...
 
     @overload
-    def __get__(  # redefinion of unused member
-        self, _instance: _C, _owner_type: Optional[Type[_C]] = None
-    ) -> _V: ...
+    def __get__(self, _instance: _C, _owner_type: Optional[Type[_C]] = None) -> _V: ...
 
-    def __get__(  # redefinion of unused member
+    def __get__(
         self, _instance: Optional[_C], _owner_type: Optional[Type[_C]] = None
     ) -> _V | NonDataDescriptor[_C, _V]: ...
 
@@ -351,7 +349,7 @@ def extended_runtime_checkable(
 ) -> _ProtoT: ...
 
 
-def extended_runtime_checkable(  # too complex but unavoidable
+def extended_runtime_checkable(
     maybe_cls: Optional[_ProtoT] = None,
     *,
     instance_check_shortcut: bool = True,
@@ -697,7 +695,7 @@ class CallableKwargsInfo:
     data: Dict[str, Any]
 
 
-def infer_type(  # function is complex but well organized in independent cases
+def infer_type(
     value: Any,
     *,
     annotate_callable_kwargs: bool = False,

src/gt4py/eve/type_definitions.py

@@ -19,7 +19,7 @@
 import abc
 import re
 import sys
-from enum import Enum as Enum, IntEnum as IntEnum  # imported but unused
+from enum import Enum as Enum, IntEnum as IntEnum
 
 from boltons.typeutils import classproperty as classproperty
 from frozendict import frozendict as _frozendict
@@ -42,7 +42,7 @@
 _Tc = TypeVar("_Tc", covariant=True)
 
 
-class FrozenList(Tuple[_Tc, ...], metaclass=abc.ABCMeta):  # no abstract methods
+class FrozenList(Tuple[_Tc, ...], metaclass=abc.ABCMeta):
     """Tuple subtype which works as an alias of ``Tuple[_Tc, ...]``."""
 
     __slots__ = ()

src/gt4py/eve/type_validation.py

@@ -112,7 +112,7 @@ def __call__(
     ) -> FixedTypeValidator: ...
 
     @overload
-    def __call__(  # redefinion of unused member
+    def __call__(
         self,
         type_annotation: TypeAnnotation,
         name: Optional[str] = None,
@@ -124,7 +124,7 @@ def __call__(  # redefinion of unused member
     ) -> Optional[FixedTypeValidator]: ...
 
     @abc.abstractmethod
-    def __call__(  # redefinion of unused member
+    def __call__(
         self,
         type_annotation: TypeAnnotation,
         name: Optional[str] = None,
@@ -169,7 +169,7 @@ def __call__(
     ) -> FixedTypeValidator: ...
 
     @overload
-    def __call__(  # redefinion of unused member
+    def __call__(
         self,
         type_annotation: TypeAnnotation,
         name: Optional[str] = None,
@@ -180,7 +180,7 @@ def __call__(  # redefinion of unused member
         **kwargs: Any,
     ) -> Optional[FixedTypeValidator]: ...
 
-    def __call__(  # redefinion of unused member / complex but well organized in cases
+    def __call__(
         self,
         type_annotation: TypeAnnotation,
         name: Optional[str] = None,

src/gt4py/next/embedded/operators.py

@@ -46,7 +46,7 @@ def __call__(  # type: ignore[override]
         self,
         *args: common.Field | core_defs.Scalar,
         **kwargs: common.Field | core_defs.Scalar,  # type: ignore[override]
-    ) -> common.Field:  # we cannot properly type annotate relative to self.fun
+    ) -> common.Field:
         scan_range = embedded_context.closure_column_range.get()
         assert self.axis == scan_range[0]
         scan_axis = scan_range[0]

src/gt4py/next/ffront/field_operator_ast.py

@@ -51,7 +51,7 @@ def __str__(self):
 #       class Symbol(eve.GenericNode, LocatedNode, Generic[SymbolT]):
 #
 class Symbol(LocatedNode, Generic[SymbolT]):
-    id: Coerced[SymbolName]  # shadowing a python builtin
+    id: Coerced[SymbolName]
     type: Union[SymbolT, ts.DeferredType]  # A003
     namespace: dialect_ast_enums.Namespace = dialect_ast_enums.Namespace(
         dialect_ast_enums.Namespace.LOCAL
@@ -79,7 +79,7 @@ class Expr(LocatedNode):
 
 
 class Name(Expr):
-    id: Coerced[SymbolRef]  # shadowing a python builtin
+    id: Coerced[SymbolRef]
 
 
 class Constant(Expr):
@@ -157,7 +157,7 @@ class Stmt(LocatedNode): ...
 
 
 class Starred(Expr):
-    id: Union[FieldSymbol, TupleSymbol, ScalarSymbol]  # shadowing a python builtin
+    id: Union[FieldSymbol, TupleSymbol, ScalarSymbol]
 
 
 class Assign(Stmt):
@@ -198,23 +198,23 @@ def _collect_common_symbols(cls: type[IfStmt], instance: IfStmt) -> None:
 
 
 class FunctionDefinition(LocatedNode, SymbolTableTrait):
-    id: Coerced[SymbolName]  # shadowing a python builtin
+    id: Coerced[SymbolName]
     params: list[DataSymbol]
     body: BlockStmt
     closure_vars: list[Symbol]
     type: Union[ts.FunctionType, ts.DeferredType] = ts.DeferredType(constraint=ts.FunctionType)
 
 
 class FieldOperator(LocatedNode, SymbolTableTrait):
-    id: Coerced[SymbolName]  # shadowing a python builtin
+    id: Coerced[SymbolName]
     definition: FunctionDefinition
     type: Union[ts_ffront.FieldOperatorType, ts.DeferredType] = ts.DeferredType(
         constraint=ts_ffront.FieldOperatorType
     )
 
 
 class ScanOperator(LocatedNode, SymbolTableTrait):
-    id: Coerced[SymbolName]  # shadowing a python builtin
+    id: Coerced[SymbolName]
     axis: Constant
     forward: Constant
     init: Constant