Skip to content

Commit 0d158ad

Browse files
authored
fix[next][dace]: Fix for neighbor reduction with skip values (#1443)
This PR provides a bugfix for the case of neighbor reductions with lambda function as reduction operation and connectivity table containing skip values. The lambda function should only accumulate the results for the valid neighbors. On the contrary, the baseline implementation was using the reduction identity value for the missing neighbors, resulting in invalid result. The fix consists of producing an array of boolean flags to determine if the neighbor value is valid or not. If not valid, the call to the lambda function is by-passed.
1 parent 58ec4dd commit 0d158ad

File tree

3 files changed

+200
-67
lines changed

3 files changed

+200
-67
lines changed

src/gt4py/next/program_processors/runners/dace_iterator/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ def build_sdfg_from_itir(
299299
for nested_sdfg in sdfg.all_sdfgs_recursive():
300300
if not nested_sdfg.debuginfo:
301301
_, frameinfo = warnings.warn(
302-
f"{nested_sdfg} does not have debuginfo. Consider adding them in the corresponding nested sdfg."
302+
f"{nested_sdfg.label} does not have debuginfo. Consider adding them in the corresponding nested sdfg."
303303
), getframeinfo(
304304
currentframe() # type: ignore
305305
)

0 commit comments

Comments
 (0)