Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking issue for refactoring the Table trait and related structures #2065

Closed
8 tasks done
waynexia opened this issue Aug 2, 2023 · 3 comments
Closed
8 tasks done
Assignees
Labels
C-enhancement Category Enhancements tracking-issue A tracking issue for a feature.

Comments

@waynexia
Copy link
Member

waynexia commented Aug 2, 2023

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

With table engine in datanode being replaced by region engine in #1869, we should also reconsider the Table abstraction. Generally speaking, the datanode (or region server) will no longer be aware of table -- it only sees and handles regions. And consequently, all the data access kind API (read, write, delete etc.) should be removed from Table. This makes the Table trait only in response of metadata, like retrieving table info or table schema.

This change will be shipped in the following parts:

Implementation challenges

No response

@waynexia
Copy link
Member Author

Close as completed

@tisonkun
Copy link
Collaborator

tisonkun commented Apr 7, 2024

@waynexia @zhongzc But we still have the Table trait and Arc<dyn Table> in many places. Shall we continue on this direction?

@tisonkun
Copy link
Collaborator

tisonkun commented Apr 7, 2024

I'm trying to drop the Table trait ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements tracking-issue A tracking issue for a feature.
Projects
None yet
Development

No branches or pull requests

3 participants