Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant Step with Boolean Should Output Lowercase for Cosmos #1068

Closed
n-ate opened this issue Jun 21, 2023 · 5 comments
Closed

Constant Step with Boolean Should Output Lowercase for Cosmos #1068

n-ate opened this issue Jun 21, 2023 · 5 comments

Comments

@n-ate
Copy link

n-ate commented Jun 21, 2023

Describe the bug

The constant step with any boolean value seems to always resolve to uppercase True or False.

Expected behavior
Cosmos expects lowercase true or false for boolean constants.

Version information
v11.1

Minimal working example

C# Gremlinq:
g.V().Limit(1).Constant(true);

Actual Output:
g.V().limit(1).constant(True)

Cosmos Error:
Unable to resolve symbol 'True' in the current context.

Expected Output:
g.V().limit(1).constant(true)

Work Around
C# Gremlinq:
g.V().Limit(1).Constant(1);

Then evaluate the response:
var result = response == 1;

@danielcweber
Copy link
Contributor

How do come to the output 'g.V().limit(1).constant(True)' ? I can't reproduce this as Debug-output and for query serialization, the boolean parameters aren't inlined anyway. I'd need repro code.

@github-actions
Copy link
Contributor

Hello @n-ate,
thanks for your interest in ExRam.Gremlinq. The issue was labelled "Repro repository missing" because although the issue template asks for either "a link to GitHub repository containing a minimal executable project structure that exposes the unexpected behaviour" or "a pull request to ExRam.Gremlinq that adds a failing unit test to the ExRam.Gremlinq tests asserting the expected behaviour", it seems you provided neither. Most problems already solve themselves when isolated and if they don't, you will have made it easier for the maintainer of this project to investigate a possible bug.

@n-ate
Copy link
Author

n-ate commented Jun 22, 2023

Thanks for taking a look at it daniel. Luckily there is a simple workaround.

@danielcweber
Copy link
Contributor

As commented above, I'd like to comprehend how you get to the output g.V().limit(1).constant(True). I'd like to see the code that produces this.

@danielcweber
Copy link
Contributor

Closing due to lack of feedback by OP and impossibility to reproduce on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants