EvilCraft + GTM Potion Bottle NBT

[loving2]

Checked for existing issues

• I have checked for existing issues, and have found none.

Tested latest version

• I have checked that this occurs on the latest version.

GregTech CEu Version

v1.6.2

Minecraft Version

1.20.1 Forge

Recipe Viewer Installed

JEI

Environment

Singleplayer

Cross-Mod Interaction

Yes

Other Installed Mods

• EvilCraft v1.2.49

Expected Behavior

Crafting a Night Vision Minecraft:Potion should have just 1 NBT {Potion: "minecraft:night_vision"}

Actual Behavior

All Potions have an additional NBT stored on them, making their NBT look like {Potion: "minecraft:night_vision", Fluid: {Tag: {Potion: "minecraft:night_vision"}, FluidName: "gtceu:potion", Amount: 250}}

Steps to Reproduce

1. Install EvilCraft and GTM
2. Cheat in any potion bottle
3. Toggle F3+H or use /data get entity @s SelectedItem
4. Notice the additional NBT

Additional Information

I've also made an issue here for EvilCraft, as I'm not sure where the additional tag is coming from.

This additional tag breaks crafting recipes from any other mod that uses potions for crafting items, for example Draconic Evolution's Damage Module.

[loving2]

I think I've found the conflict. I'm not sure how or why this happens, but it appears because GT attaches a FluidHandlerItemStack.SwapEmpty capability to PotionItem and something in EvilCraft must be calling the setFluid method on it which writes the Fluid tag. I believe I have a fix in my local instance, will PR it shortly.