Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check usage of global variables #240

Open
bernd opened this issue Jun 27, 2018 · 0 comments
Open

Check usage of global variables #240

bernd opened this issue Jun 27, 2018 · 0 comments

Comments

@bernd
Copy link
Member

bernd commented Jun 27, 2018

Problem description

We are using global registries in some places which are not thread-safe and we have to check if this can become a problem.

I found global registries here:

  • system/status.go: GlobalStatus = &Status{}
  • assignments/assignment.go: Store = &assignmentStore{make(map[string]string)}
  • backends/registry.go: Store = &backendStore{backends: make(map[string]*Backend)}

We should check if there are more.

@bernd bernd added this to the 3.0.0 milestone Jun 27, 2018
@bernd bernd removed this from the 3.0.0 milestone Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants