improve ImageSaver error dialog

- include OS version
- include app package name and versionCode
- use the standard stack trace format

Author: muhomorr

app/src/main/java/app/grapheneos/camera/capturer/ImageCapturer.kt

@@ -8,12 +8,12 @@ import android.app.NotificationManager
 import android.content.ClipData
 import android.content.ClipboardManager
 import android.graphics.Bitmap
+import android.os.Build
 import android.util.Log
 import android.view.View
 import android.view.animation.AlphaAnimation
 import android.view.animation.Animation
 import android.view.animation.LinearInterpolator
-import android.widget.FrameLayout
 import androidx.camera.core.CameraSelector
 import androidx.camera.core.ImageCapture
 import androidx.camera.core.ImageCaptureException
@@ -22,6 +22,7 @@ import app.grapheneos.camera.CapturedItem
 import app.grapheneos.camera.R
 import app.grapheneos.camera.ui.activities.MainActivity
 import app.grapheneos.camera.ui.activities.SecureMainActivity
+import app.grapheneos.camera.util.printStackTraceToString
 
 private const val imageFileFormat = ".jpg"
 var isTakingPicture: Boolean = false
@@ -198,12 +199,16 @@ class ImageCapturer(val mActivity: MainActivity) {
         AlertDialog.Builder(ctx).apply {
             setMessage(message)
             setPositiveButton(R.string.show_details) { _, _ ->
-                val list = exception.asStringList()
+                val pkgName = ctx.packageName
+                val pkgVersion = ctx.packageManager.getPackageInfo(pkgName, 0).longVersionCode
+                val text = "osVersion: ${Build.FINGERPRINT}" +
+                        "\npackage: $pkgName:$pkgVersion" +
+                        "\n\n${exception.printStackTraceToString()}"
 
                 AlertDialog.Builder(ctx).apply {
-                    setItems(list.toTypedArray(), null)
+                    setItems(text.lines().toTypedArray(), null)
                     setNeutralButton(R.string.copy_to_clipboard) { _, _ ->
-                        val clipData = ClipData.newPlainText(exception.javaClass.name, list.joinToString("\n"))
+                        val clipData = ClipData.newPlainText(exception.javaClass.name, text)
                         val cm = mActivity.getSystemService(ClipboardManager::class.java)
                         cm.setPrimaryClip(clipData)
                         ctx.showMessage(R.string.copied_text_to_clipboard)

app/src/main/java/app/grapheneos/camera/capturer/ImageSaverException.kt

@@ -10,30 +10,3 @@ class ImageSaverException(val place: Place, cause: Exception? = null) : Exceptio
         FILE_WRITE_COMPLETION,
     }
 }
-
-fun Throwable.asStringList() : List<String> {
-    val list = ArrayList<String>()
-
-    val chain = ArrayList<Throwable>()
-    var tail: Throwable? = this
-    do {
-        chain.add(tail!!)
-        tail = tail.cause
-    } while (tail != null)
-
-    chain.reversed().forEachIndexed { index, entry ->
-        if (chain.size != 1) {
-            list.add("--- Exception ${index + 1} / ${chain.size}")
-        }
-
-        list.add(entry.javaClass.name)
-        entry.message?.let {
-            list.add(it)
-        }
-
-        entry.stackTrace.forEach {
-            list.add("${it.methodName}  ::  ${it.className}  ::  ${it.lineNumber}")
-        }
-    }
-    return list
-}

app/src/main/java/app/grapheneos/camera/util/Utils.kt

@@ -11,10 +11,18 @@ import app.grapheneos.camera.CamConfig
 import app.grapheneos.camera.R
 import app.grapheneos.camera.capturer.DEFAULT_MEDIA_STORE_CAPTURE_PATH
 import app.grapheneos.camera.capturer.SAF_URI_HOST_EXTERNAL_STORAGE
+import java.io.ByteArrayOutputStream
 import java.io.IOException
+import java.io.PrintStream
 import java.util.concurrent.ExecutorService
 import java.util.concurrent.RejectedExecutionException
 
+fun Throwable.printStackTraceToString(): String {
+    val baos = ByteArrayOutputStream(1000)
+    this.printStackTrace(PrintStream(baos));
+    return baos.toString()
+}
+
 fun getTreeDocumentUri(treeUri: Uri): Uri {
     val treeId = DocumentsContract.getTreeDocumentId(treeUri)
     return DocumentsContract.buildDocumentUriUsingTree(treeUri, treeId)