Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-photo-gallery #10444

Closed
swissspidy opened this issue Feb 3, 2022 · 3 comments · Fixed by #10463 or #10737
Closed

Replace react-photo-gallery #10444

swissspidy opened this issue Feb 3, 2022 · 3 comments · Fixed by #10463 or #10737
Assignees
Labels
Group: Library Group: Media Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Feb 3, 2022

Feature Description

The react-photo-gallery package we're using for the media library hasn't been updated in over 3 years.

We already had to patch it once in #4438 because of the outstanding bugfix in neptunian/react-photo-gallery#184 that hasn't been merged to this day.

Another issue is that the library doesn't officially declare support for React 17, causing some issues with duplicated React dependencies (neptunian/react-photo-gallery#205).

I think it's time we look for alternatives.

One often named alternative is https://github.com/igordanchenko/react-photo-album which has a very similar API. Docs: https://react-photo-album.com/

My hope is that it's gonna be almost a drop-in replacement.

Alternatives Considered

Additional Context

@swissspidy
Copy link
Collaborator Author

Another reason for a replacement:

#10597 (comment)

@swissspidy swissspidy changed the title Consider replacing react-photo-gallery Replace react-photo-gallery Feb 28, 2022
@swissspidy swissspidy reopened this Feb 28, 2022
@swissspidy
Copy link
Collaborator Author

Assigning to Prometheus pod as per discussion with @miina

#10737 solves this, but needs figuring out why drop targets don't seem to work reliably anymore.

See thread at https://xwp.slack.com/archives/CCCAUAH6F/p1645802324147119 for some context

@miina miina self-assigned this Mar 2, 2022
@felipebochehin87
Copy link

Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/, using PR 10737.

  1. Regressed adding images from library to canvas
  2. Regressed adding videos from library to canvas
  3. Regressed drag and drop from local to canvas
  4. Regressed upload images from local to insert to canvas
  5. Regressed upload videos from local to insert to canvas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Library Group: Media Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
3 participants