From 3264e81893be90ae552954920722256a5ca71268 Mon Sep 17 00:00:00 2001 From: balopat Date: Thu, 9 May 2019 17:02:37 -0700 Subject: [PATCH] cut v0.29.0 --- CHANGELOG.md | 72 +++++++++++++++++++ examples/bazel/skaffold.yaml | 2 +- examples/getting-started/skaffold.yaml | 2 +- examples/helm-deployment/skaffold.yaml | 2 +- examples/jib-multimodule/skaffold.yaml | 2 +- examples/jib/skaffold.yaml | 2 +- examples/kaniko-local/skaffold.yaml | 2 +- examples/kaniko/skaffold.yaml | 2 +- examples/kustomize/skaffold.yaml | 2 +- examples/microservices/skaffold.yaml | 2 +- examples/nodejs/backend/Dockerfile | 4 +- examples/nodejs/backend/src/index.js | 12 ++-- examples/nodejs/backend/src/utils/index.js | 6 +- examples/nodejs/skaffold.yaml | 11 +-- examples/react-reload/skaffold.yaml | 2 +- examples/structure-tests/skaffold.yaml | 2 +- .../skaffold.yaml | 2 +- 17 files changed, 103 insertions(+), 26 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20996a3c665..342d7a2449a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,75 @@ +# v0.29.0 Release - 05/09/2019 + +*Note*: This release comes with a new config version `v1beta10`. + To upgrade your `skaffold.yaml`, use `skaffold fix`. If you don't upgrade, skaffold will auto-upgrade in memory as best it can, and print a warning message. + See [deprecation-policy.md](/deprecation-policy.md) for details on what beta means. + +New Features: + +* Add command to custom artifact dependencies [#2095](https://github.com/GoogleContainerTools/skaffold/pull/2095) +* Improve syntax for artifact.sync config [1/3] [#1847](https://github.com/GoogleContainerTools/skaffold/pull/1847) +* Add dockerfile to custom dependencies [#2049](https://github.com/GoogleContainerTools/skaffold/pull/2049) +* Automatically watch helm subcharts when skipBuildDependencies is enabled [#1371](https://github.com/GoogleContainerTools/skaffold/pull/1371) +* Allow environment variables to be used in docker build argument [#1912](https://github.com/GoogleContainerTools/skaffold/pull/1912) +* Add option to configure the networking stack in docker build [#2036](https://github.com/GoogleContainerTools/skaffold/pull/2036) +* Allow --no-cache to be passed to docker [#2054](https://github.com/GoogleContainerTools/skaffold/pull/2054) +* Deploy to consume build output [#2001](https://github.com/GoogleContainerTools/skaffold/pull/2001) +* Add k8 style managed by label to skaffold deployed pods [#2055](https://github.com/GoogleContainerTools/skaffold/pull/2055) +* Support kubectl deploy absolute manifest files [#2011](https://github.com/GoogleContainerTools/skaffold/pull/2011) + +Bug Fixes: + +* Add custom artifact for custom local builds [#1999](https://github.com/GoogleContainerTools/skaffold/pull/1999) +* Add version as unknown if version.Get().Version is empty [#2097](https://github.com/GoogleContainerTools/skaffold/pull/2097) +* Fix image release process: master -> edge, tag -> latest [#2099](https://github.com/GoogleContainerTools/skaffold/pull/2099) +* :bug: fix kubectl apply error handling [#2076](https://github.com/GoogleContainerTools/skaffold/pull/2076) +* Remove podname from port forward key [#2047](https://github.com/GoogleContainerTools/skaffold/pull/2047) +* Correctly parse env-var for multi-valued flags [#2032](https://github.com/GoogleContainerTools/skaffold/pull/2032) + +Updates & refactoring: + +* Prefix Skaffold labels with 'skaffold-' [#2062](https://github.com/GoogleContainerTools/skaffold/pull/2062) +* Remove copy paste deploy_test.go [#2085](https://github.com/GoogleContainerTools/skaffold/pull/2085) +* Freeze v1beta9 config [#2035](https://github.com/GoogleContainerTools/skaffold/pull/2035) +* Add unit test for port forwarding key [#2059](https://github.com/GoogleContainerTools/skaffold/pull/2059) +* Refactor kaniko builder to cluster builder [#2037](https://github.com/GoogleContainerTools/skaffold/pull/2037) +* Attaching os standard error and out stream to the copy command [#1960](https://github.com/GoogleContainerTools/skaffold/pull/1960) + +Docs updates: + +* Mention kind in docs for local development [#2090](https://github.com/GoogleContainerTools/skaffold/pull/2090) +* Clarify which containers are port forwarded [#2078](https://github.com/GoogleContainerTools/skaffold/pull/2078) +* Improve nodejs example to show subdirectories sync [#2024](https://github.com/GoogleContainerTools/skaffold/pull/2024) +* Minor fix on Markdown to follow markdown rules [#2052](https://github.com/GoogleContainerTools/skaffold/pull/2052) +* Note filesync limitation for files not owned by container user [#2041](https://github.com/GoogleContainerTools/skaffold/pull/2041) + +Design proposals: + +* Design proposal for sync improvements [#1844](https://github.com/GoogleContainerTools/skaffold/pull/1844) + + +Huge thanks goes out to all of our contributors for this release: + +- Balint Pato +- Brian de Alwis +- Byungjin Park +- Charles-Henri GUÉRIN +- Cornelius Weig +- David Gageot +- Dmitri Moore +- Ilyes Hammadi +- Nick Kubala +- peter +- Pierre-Yves Aillet +- Prashant Arya +- Priya Wadhwa +- Rahul Sinha +- robertrbruno +- Tejal Desai +- Tigran Tch +- Xiaoxi He + + # v0.28.0 Release - 04/25/2019 *Note*: This release comes with a new config version `v1beta9`. diff --git a/examples/bazel/skaffold.yaml b/examples/bazel/skaffold.yaml index 31aacc5d583..ab1f0a85340 100644 --- a/examples/bazel/skaffold.yaml +++ b/examples/bazel/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/getting-started/skaffold.yaml b/examples/getting-started/skaffold.yaml index 4ba1741eae5..3eedc1153d0 100644 --- a/examples/getting-started/skaffold.yaml +++ b/examples/getting-started/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/helm-deployment/skaffold.yaml b/examples/helm-deployment/skaffold.yaml index 2ec83f1a6bb..62371e20026 100644 --- a/examples/helm-deployment/skaffold.yaml +++ b/examples/helm-deployment/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: tagPolicy: diff --git a/examples/jib-multimodule/skaffold.yaml b/examples/jib-multimodule/skaffold.yaml index 6067b71be16..bc693cf6470 100644 --- a/examples/jib-multimodule/skaffold.yaml +++ b/examples/jib-multimodule/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/jib/skaffold.yaml b/examples/jib/skaffold.yaml index b362c9bf3dc..affe4a915c6 100644 --- a/examples/jib/skaffold.yaml +++ b/examples/jib/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/kaniko-local/skaffold.yaml b/examples/kaniko-local/skaffold.yaml index 8ba0e0dd9f0..8abe6cfc04b 100644 --- a/examples/kaniko-local/skaffold.yaml +++ b/examples/kaniko-local/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/kaniko/skaffold.yaml b/examples/kaniko/skaffold.yaml index 56a150f65ac..f7aee47420f 100644 --- a/examples/kaniko/skaffold.yaml +++ b/examples/kaniko/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/kustomize/skaffold.yaml b/examples/kustomize/skaffold.yaml index cf0538f419b..dc01c6930db 100644 --- a/examples/kustomize/skaffold.yaml +++ b/examples/kustomize/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config deploy: kustomize: {} diff --git a/examples/microservices/skaffold.yaml b/examples/microservices/skaffold.yaml index 6c8072da52c..10a758fc9f5 100644 --- a/examples/microservices/skaffold.yaml +++ b/examples/microservices/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/nodejs/backend/Dockerfile b/examples/nodejs/backend/Dockerfile index 9f679678e41..01ef927e8e4 100644 --- a/examples/nodejs/backend/Dockerfile +++ b/examples/nodejs/backend/Dockerfile @@ -1,8 +1,10 @@ FROM node:8.12.0-alpine +ARG SCRIPT +ENV SCRIPT ${SCRIPT} WORKDIR /opt/backend EXPOSE 3000 -CMD ["npm", "run", "dev"] +CMD ["npm", "run", ${SCRIPT}] COPY . . RUN npm install diff --git a/examples/nodejs/backend/src/index.js b/examples/nodejs/backend/src/index.js index 50c698dcee5..4605db1dc66 100644 --- a/examples/nodejs/backend/src/index.js +++ b/examples/nodejs/backend/src/index.js @@ -1,8 +1,8 @@ -const express = require("express"); -const { echo } = require("./utils"); -const app = express(); -const port = 3000; +const express = require('express') +const { echo } = require('./utils'); +const app = express() +const port = 3000 -app.get("/", (req, res) => res.send(echo("Hello World!"))); +app.get('/', (req, res) => res.send(echo('Hello World!'))) -app.listen(port, () => console.log(`Example app listening on port ${port}!`)); +app.listen(port, () => console.log(`Example app listening on port ${port}!`)) diff --git a/examples/nodejs/backend/src/utils/index.js b/examples/nodejs/backend/src/utils/index.js index b86862fa759..d77d34a8c99 100644 --- a/examples/nodejs/backend/src/utils/index.js +++ b/examples/nodejs/backend/src/utils/index.js @@ -1,7 +1,7 @@ function echo(string) { - return string; + return string; } module.exports = { - echo -}; + echo +} \ No newline at end of file diff --git a/examples/nodejs/skaffold.yaml b/examples/nodejs/skaffold.yaml index df9aa148456..5b15608c1a3 100644 --- a/examples/nodejs/skaffold.yaml +++ b/examples/nodejs/skaffold.yaml @@ -4,12 +4,15 @@ build: artifacts: - image: gcr.io/k8s-skaffold/node-example context: backend + docker: + buildArgs: + SCRIPT: "{{.SCRIPT}}" sync: manual: - # Sync all the javascript files that are in the src folder - # with the container src folder - - src: 'src/**/*.js' - dest: . + # Sync all the javascript files that are in the src folder + # with the container src folder + - src: 'src/**/*.js' + dest: . deploy: kubectl: manifests: diff --git a/examples/react-reload/skaffold.yaml b/examples/react-reload/skaffold.yaml index f44b5685d56..2adfa800c88 100644 --- a/examples/react-reload/skaffold.yaml +++ b/examples/react-reload/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/structure-tests/skaffold.yaml b/examples/structure-tests/skaffold.yaml index c8d27422cf4..a6e566129ab 100644 --- a/examples/structure-tests/skaffold.yaml +++ b/examples/structure-tests/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: diff --git a/examples/tagging-with-environment-variables/skaffold.yaml b/examples/tagging-with-environment-variables/skaffold.yaml index 70073d970b1..23242d5b626 100644 --- a/examples/tagging-with-environment-variables/skaffold.yaml +++ b/examples/tagging-with-environment-variables/skaffold.yaml @@ -1,4 +1,4 @@ -apiVersion: skaffold/v1beta9 +apiVersion: skaffold/v1beta10 kind: Config build: artifacts: