Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated reference at the end of the NLP crown jewel Encoder decoder lab (rnn_encoder_decoder.ipynb) #2437

Open
MrCsabaToth opened this issue Sep 10, 2023 · 1 comment · May be fixed by #2438

Comments

@MrCsabaToth
Copy link

In my opinion this is the crown jewel lab of the whole NLP course of the Machine Learning Engineer learning path. The CSB (Cloud Skills Boost) lab is titled simply "Encoder decoder" (https://www.cloudskillsboost.google/course_sessions/2920308/labs/363239), while the notebook title tells away more "Simple RNN Encode-Decoder for Translation" https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/courses/machine_learning/deepdive2/text_classification/labs/rnn_encoder_decoder.ipynb

This is no biggie but the reference at the end is 404. I believe the correct link now is https://github.com/keras-team/keras-io/blob/master/examples/nlp/lstm_seq2seq.py which is also authored by Francois Chollet.

As usual (when it's not a CSB correction), I'm crafting a PR.

@MrCsabaToth MrCsabaToth changed the title Deprecated reference at the end of the LMM crown jewel Encoder decoder lab (rnn_encoder_decoder.ipynb) Deprecated reference at the end of the NLP crown jewel Encoder decoder lab (rnn_encoder_decoder.ipynb) Sep 10, 2023
@MrCsabaToth
Copy link
Author

The referenced notebook is great because it's somewhat different so it could add a little more to the material. It uses for example LSTM instead of GRU.

MrCsabaToth added a commit to MrCsabaToth/training-data-analyst that referenced this issue Sep 10, 2023
@MrCsabaToth MrCsabaToth linked a pull request Sep 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant