feat(trace-exporter): use the same resource mapping for metrics and traces #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…races In the trace exporter, stop passing `includeUnsupportedResources` param (false by default). This param controls if the mapping function should return `cloud_run_revision` and `cloud_function` monitored resources. This is equivalent to what we do in [Go](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/v0.44.0/internal/resourcemapping/resourcemapping.go) and Java GoogleCloudPlatform/opentelemetry-operations-java#250 Deprecate the `includeUnsupportedResources` parameter by splitting the function def into a deprecated and non-deprecated overload. It is no longer needed but the package is marked stable so I will save the breaking change.
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 18 18
Lines 693 693
Branches 129 129
=======================================
Hits 677 677
Misses 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
force-pushed
the
same-resource-mappings
branch
from
eae7a2b to
8f9fad7
Compare
dashpole
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
Deprecate the
includeUnsupportedResourcesparameter by splitting the function def into a deprecated and non-deprecated overload. It is no longer needed as we decide that trace and monitoring exporters should do the exact same resource mapping. The package is marked stable so I full removal would be a breaking change.This is equivalent to what we do in Go and Java GoogleCloudPlatform/opentelemetry-operations-java#250