Support SQL Server Switchover (after resolving conflicts)

[Philip-Jonany]

Support SQL Server Switchover through terraform
The full design doc can be found in go/sqlserver-switchover-terraform-proposal (Googler-only)

*This CL will NOT be submitted until the API changes are rolled out, and that my manual testing passes without causing a permadiff.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[slevenick]

Overall no major concerns as long as the tests pass and the functionality works correctly

[slevenick]

Are there docs on how this should work from an outside of Terraform perspective?

I'm having trouble figuring out why we expect switchover to only work if the new replica configuration is empty

[Philip-Jonany]

In his function, we check that the old replica has a replica configuration. If it's not set or empty, we return false === invalid, don't do switchover. This is a check for isEmpty before I access cascadable_replica, which is under replica_configuration.

go/sqlserver-switchover-terraform-proposal contains the user journey through terraform switchover.

[slevenick]

This is a very confusing return statement to parse. Can you split this out somehow? I'd even prefer nested if statements

[Philip-Jonany]

I split the related booleans into variables such as instanceTypeChangedFromPrimaryToReplica and newMasterNotInNewReplicaNames, hopefully this makes it cleaner. Open to suggestions to renaming/rearranging the boolean!

[Philip-Jonany]

Two main changes:
File got refactored from .go.erb to .go.tmpl
Added customdiff for cascadable_replica: force replacement unless it's switchover.

[Philip-Jonany]

In his function, we check that the old replica has a replica configuration. If it's not set or empty, we return false === invalid, don't do switchover. This is a check for isEmpty before I access cascadable_replica, which is under replica_configuration.

go/sqlserver-switchover-terraform-proposal contains the user journey through terraform switchover.

[Philip-Jonany]

I split the related booleans into variables such as instanceTypeChangedFromPrimaryToReplica and newMasterNotInNewReplicaNames, hopefully this makes it cleaner. Open to suggestions to renaming/rearranging the boolean!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 493 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 4 files changed, 493 insertions(+), 17 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (140 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  replica_configuration {
    ca_certificate     = # value needed
    client_certificate = # value needed
    client_key         = # value needed
    dump_file_path     = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 99
Passed tests: 84
Skipped tests: 14
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_SwitchoverSuccess

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SwitchoverSuccess[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test