-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing custom-metrics-stackdriver-adapter trace logging enabled #640
Comments
qq: does this issue happen starting from v0.14.2-gke.0? |
I believe this has been going on for a while. We're on
|
Thanks for providing this information! |
/label custom-metrics-stackdriver-adapter |
btw, @supersam654 did you find high memory issue in v0.12.2-gke.0? If so, try v0.14.2-gke.0 which fixed OOM/high memory issue. Release note is here https://github.com/GoogleCloudPlatform/k8s-stackdriver/releases/tag/cm-sd-adapter-v0.14.0 |
These traces log are ignorable. Could you try increasing log level by
Trace prints out because whatever action the trace is about takes longer than what the author expects. This is expected for metrics adapter because it fetches data from Cloud Monitoring. |
Since the last version (0.15) this now outputs:
when trying to mute Trace output. I think something broke the klog flag parsing. Maybe the initialisation order is wrong? Update: the # How to use klog
1. Replace imports for "github.com/golang/glog" with "k8s.io/klog/v2"
2. Use klog.InitFlags(nil) explicitly for initializing global flags as we no longer use init() method to register the flags |
Our main problem with this is that the latter go (logs starting with "Trace") end up in stderr, and are therefore classified as "Error" in GCP Cloud Logging, falsely triggering as a problem in our monitoring. |
It appears that in
gcr.io/gke-release/custom-metrics-stackdriver-adapter:v0.14.2-gke.0
, traces are enabled and logging to stdout.We're using the manifests from this commit reference https://github.com/GoogleCloudPlatform/k8s-stackdriver/blob/303ec9ad1ca8d09e2ea93a7ff2ce3aea7a9f8a97/custom-metrics-stackdriver-adapter/deploy/production/adapter.yaml,
We end up with an enormous amount of logs like below:
The text was updated successfully, but these errors were encountered: